1846796 - Make H264-annexb work on Mac

Status: RESOLVED FIXED

(Core :: Audio/Video: Web Codecs, task, P1)

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1846796 - Set extra data only when description is given

The extra data may be set to the default one with guessed values. We
should only set it when description data is provided.

Comment 2

[C.M.Chang[:chunmin]]

Attachment: Bug 1846796 - Parse extra data from converted avcc data

When converting h264 stream in annexb format into avcc format, the fake
extra data is attached to converted stream.

This patch addes a function to parse the extra data from the converted
avcc stream, and attach the parsed extra data instead of the fake one to
the stream.

Depends on D185193

Comment 3

[C.M.Chang[:chunmin]]

Attachment: Bug 1846796 - Enable on WebCodecs on Mac OS

Depends on D185194

Comment 4

[C.M.Chang[:chunmin]]

Attachment: Bug 1846796 - Change expectations in VideoDecoder's WPTs

Depends on D185195

Comment 5

[C.M.Chang[:chunmin]]

Attachment: Bug 1846796 - Read a Span of data via BufferReader

Depends on D185196

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1049437363a5
Set extra data only when description is given r=padenot
https://hg.mozilla.org/integration/autoland/rev/04790724edf0
Parse extra data from converted avcc data r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/e940c4fa9ec3
Enable on WebCodecs on Mac OS r=padenot
https://hg.mozilla.org/integration/autoland/rev/be824cbe5189
Change expectations in VideoDecoder's WPTs r=padenot
https://hg.mozilla.org/integration/autoland/rev/70417eb0e3bd
Read a Span of data via BufferReader r=media-playback-reviewers,padenot

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1049437363a5
https://hg.mozilla.org/mozilla-central/rev/04790724edf0
https://hg.mozilla.org/mozilla-central/rev/e940c4fa9ec3
https://hg.mozilla.org/mozilla-central/rev/be824cbe5189
https://hg.mozilla.org/mozilla-central/rev/70417eb0e3bd

Comment 8

[C.M.Chang[:chunmin]]

Patch D185194 caused the bug 1855636. We need a new fix here.

Comment 9

[C.M.Chang[:chunmin]]

Set a reminder

Comment 10

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1846796 - re-enable H.264 decoder on macOS for WebCodecs. r=chunmin

Comment 11

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1846796 - fix H.264 start code pattern matching algorithm. r=chunmin

Depends on D202543

Comment 12

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1846796 - change test expectations. r=chunmin

Depends on D202544

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05c1bb31b964
re-enable H.264 decoder on macOS for WebCodecs. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/e73aa0aa82d2
fix H.264 start code pattern matching algorithm. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/49bc41e918c2
change test expectations. r=chunmin

Comment 14

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/05c1bb31b964
https://hg.mozilla.org/mozilla-central/rev/e73aa0aa82d2
https://hg.mozilla.org/mozilla-central/rev/49bc41e918c2