Closed Bug 1846823 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 41295 - Revert "Add WPT to test rounding for adCost"

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox118 fixed)

Status:
RESOLVED FIXED
Milestone:
118 Branch
Tracking Flags:
Tracking Status
firefox118 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 41295 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41295
Details from upstream follow.

Tianyang Xu <xtlsheep@google.com> wrote:

Revert "Add WPT to test rounding for adCost"

This reverts commit 67e4f2113685c386755f87a4248b0745f77968f8.

Reason for revert: There are failed tests in some envs, e.g. mac11-arm64-rel

Original change's description:

Add WPT to test rounding for adCost

Create a new web platform test to test if adCost is rounded correctly
after returned by generateBid(). The idea is to check the adCost from
browserSignals in ReportWin() and use sendReportTo() to verify if the
rounded value are in expected URL arrays.

Bug: 1425952
Change-Id: Id042f9df9a8e78a937e0cea3396f537888fc840b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4727328
Reviewed-by: Dominic Farolino \<dom@chromium.org>
Commit-Queue: Tianyang Xu \<xtlsheep@google.com>
Reviewed-by: Russ Hamilton \<behamilton@google.com>
Reviewed-by: Xianzhu Wang \<wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1178405}

Bug: 1425952
Change-Id: I6c0f6548724b379c496204742539e76aa2547d33
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Reviewed-on: https://chromium-review.googlesource.com/4742944
WPT-Export-Revision: 2470e8bd816ab31ac949aa1b10123eb42da57fdd

PR 41295 applied with additional changes from upstream: a12487fa69e0133466ac1c5fdccd7154e3159275
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 7 tests and 46 subtests

Status Summary

Firefox

OK : 7
FAIL: 238

Chrome

OK : 7
FAIL: 238

Safari

OK : 7
FAIL: 238

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /fledge/tentative/auction-config.https.sub.window.html [wpt.fyi]
    • no buyers => no winners: FAIL (Chrome: FAIL, Safari: FAIL)
    • seller is not an https URL: FAIL (Chrome: FAIL, Safari: FAIL)
    • decisionLogicUrl is invalid: FAIL (Chrome: FAIL, Safari: FAIL)
    • decisionLogicUrl is cross-origin with seller: FAIL (Chrome: FAIL, Safari: FAIL)
    • trustedScoringSignalsUrl is invalid: FAIL (Chrome: FAIL, Safari: FAIL)
    • trustedScoringSignalsUrl is cross-origin with seller: FAIL (Chrome: FAIL, Safari: FAIL)
    • interestGroupBuyer is invalid: FAIL (Chrome: FAIL, Safari: FAIL)
    • interestGroupBuyer is not https: FAIL (Chrome: FAIL, Safari: FAIL)
    • only one interestGroupBuyer is invalid: FAIL (Chrome: FAIL, Safari: FAIL)
    • only one interestGroupBuyer is not https: FAIL (Chrome: FAIL, Safari: FAIL)
    • auctionSignals is invalid as JSON: FAIL (Chrome: FAIL, Safari: FAIL)
    • sellerSignals is invalid as JSON: FAIL (Chrome: FAIL, Safari: FAIL)
    • directFromSellerSignals is invalid: FAIL (Chrome: FAIL, Safari: FAIL)
    • directFromSellerSignals is cross-origin with seller: FAIL (Chrome: FAIL, Safari: FAIL)
    • directFromSellerSignals has nonempty query: FAIL (Chrome: FAIL, Safari: FAIL)
    • perBuyerSignals has invalid URL in a key: FAIL (Chrome: FAIL, Safari: FAIL)
    • perBuyerSignals value is invalid as JSON: FAIL (Chrome: FAIL, Safari: FAIL)
    • perBuyerGroupLimits has invalid URL in a key: FAIL (Chrome: FAIL, Safari: FAIL)
    • perBuyerExperimentGroupIds has invalid URL in a key: FAIL (Chrome: FAIL, Safari: FAIL)
    • perBuyerPrioritySignals has invalid URL in a key: FAIL (Chrome: FAIL, Safari: FAIL)
    • perBuyerPrioritySignals has a value with a key with prefix "browserSignals": FAIL (Chrome: FAIL, Safari: FAIL)
    • component auctions are not allowed within component auctions: FAIL (Chrome: FAIL, Safari: FAIL)
    • component auctions are not allowed with interestGroupBuyers: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fledge/tentative/join-leave-ad-interest-group.https.sub.window.html [wpt.fyi]
  • /fledge/tentative/no-winner.https.sub.window.html [wpt.fyi]
    • Bidding logic script: error=close-connection: FAIL (Chrome: FAIL, Safari: FAIL)
    • Bidding logic script: error=http-error: FAIL (Chrome: FAIL, Safari: FAIL)
    • Bidding logic script: error=no-content-type: FAIL (Chrome: FAIL, Safari: FAIL)
    • Bidding logic script: error=wrong-content-type: FAIL (Chrome: FAIL, Safari: FAIL)
    • Bidding logic script: error=bad-allow-fledge: FAIL (Chrome: FAIL, Safari: FAIL)
    • Bidding logic script: error=fledge-not-allowed: FAIL (Chrome: FAIL, Safari: FAIL)
    • Bidding logic script: error=no-allow-fledge: FAIL (Chrome: FAIL, Safari: FAIL)
    • Bidding logic script: error=no-body: FAIL (Chrome: FAIL, Safari: FAIL)
    • Bidding logic script: error=no-generateBid: FAIL (Chrome: FAIL, Safari: FAIL)
    • Bidding logic script: generateBid=throw 1;: FAIL (Chrome: FAIL, Safari: FAIL)
    • Bidding logic script: generateBid=This does not compile: FAIL (Chrome: FAIL, Safari: FAIL)
    • Bidding logic script: generateBid=while(1);: FAIL (Chrome: FAIL, Safari: FAIL)
    • Bidding logic script: generateBid=return 5;: FAIL (Chrome: FAIL, Safari: FAIL)
    • Bidding logic script: generateBid=return "Foo";: FAIL (Chrome: FAIL, Safari: FAIL)
    • Bidding logic script: generateBid=return interestGroup.ads[0].renderUrl;: FAIL (Chrome: FAIL, Safari: FAIL)
    • Bidding logic script: generateBid=return {bid: 1, render: "https://not-in-ads-array.test/"};: FAIL (Chrome: FAIL, Safari: FAIL)
    • Bidding logic script: generateBid=return {bid: 1};: FAIL (Chrome: FAIL, Safari: FAIL)
    • Bidding logic script: generateBid=return {render: interestGroup.ads[0].renderUrl};: FAIL (Chrome: FAIL, Safari: FAIL)
    • Bidding logic script: generateBid=return {bid:0, render: interestGroup.ads[0].renderUrl};: FAIL (Chrome: FAIL, Safari: FAIL)
    • Bidding logic script: generateBid=return {bid:-1, render: interestGroup.ads[0].renderUrl};: FAIL (Chrome: FAIL, Safari: FAIL)
    • Decision logic script: error=close-connection: FAIL (Chrome: FAIL, Safari: FAIL)
    • Decision logic script: error=http-error: FAIL (Chrome: FAIL, Safari: FAIL)
    • Decision logic script: error=no-content-type: FAIL (Chrome: FAIL, Safari: FAIL)
    • Decision logic script: error=wrong-content-type: FAIL (Chrome: FAIL, Safari: FAIL)
    • Decision logic script: error=bad-allow-fledge: FAIL (Chrome: FAIL, Safari: FAIL)
    • Decision logic script: error=fledge-not-allowed: FAIL (Chrome: FAIL, Safari: FAIL)
    • Decision logic script: error=no-allow-fledge: FAIL (Chrome: FAIL, Safari: FAIL)
    • Decision logic script: error=no-body: FAIL (Chrome: FAIL, Safari: FAIL)
    • Decision logic script: error=no-scoreAd: FAIL (Chrome: FAIL, Safari: FAIL)
    • Decision logic script: scoreAd=throw 1;: FAIL (Chrome: FAIL, Safari: FAIL)
    • Decision logic script: scoreAd=This does not compile: FAIL (Chrome: FAIL, Safari: FAIL)
    • Decision logic script: scoreAd=while(1);: FAIL (Chrome: FAIL, Safari: FAIL)
    • Decision logic script: scoreAd=return "Foo";: FAIL (Chrome: FAIL, Safari: FAIL)
    • Decision logic script: scoreAd=return {desirability: "Foo"};: FAIL (Chrome: FAIL, Safari: FAIL)
    • Decision logic script: scoreAd=return 0;: FAIL (Chrome: FAIL, Safari: FAIL)
    • Decision logic script: scoreAd=return -1;: FAIL (Chrome: FAIL, Safari: FAIL)
    • Decision logic script: scoreAd=return {desirability: 0};: FAIL (Chrome: FAIL, Safari: FAIL)
    • Decision logic script: scoreAd=return {desirability: -1};: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fledge/tentative/register-ad-beacon.https.sub.window.html [wpt.fyi]
    • Seller calls registerAdBeacon().: FAIL (Chrome: FAIL, Safari: FAIL)
    • Buyer calls registerAdBeacon().: FAIL (Chrome: FAIL, Safari: FAIL)
    • Seller calls registerAdBeacon(), beacon sent with body.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Buyer calls registerAdBeacon(), beacon sent with body.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Seller calls registerAdBeacon(). reportEvent() called twice.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Buyer calls registerAdBeacon(). reportEvent() called twice.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Seller calls registerAdBeacon() with multiple beacons.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Buyer calls registerAdBeacon() with multiple beacons.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Seller and buyer call registerAdBeacon() with shared reportEvent() call.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Seller and buyer call registerAdBeacon() with separate reportEvent() calls.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Seller calls registerAdBeacon() multiple times.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Buyer calls registerAdBeacon() multiple times.: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fledge/tentative/reporting-arguments.https.sub.window.html [wpt.fyi]
    • Seller passes number to bidder.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Seller passes string to bidder.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Seller passes array to bidder.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Seller passes object to bidder.: FAIL (Chrome: FAIL, Safari: FAIL)
    • browserSignals.topWindowHostname test.: FAIL (Chrome: FAIL, Safari: FAIL)
    • browserSignals.seller test.: FAIL (Chrome: FAIL, Safari: FAIL)
    • browserSignals.topLevelSeller and browserSignals.componentSeller test.: FAIL (Chrome: FAIL, Safari: FAIL)
    • browserSignals.renderUrl test.: FAIL (Chrome: FAIL, Safari: FAIL)
    • browserSignals.bid test.: FAIL (Chrome: FAIL, Safari: FAIL)
    • browserSignals.desirability test.: FAIL (Chrome: FAIL, Safari: FAIL)
    • browserSignals.topLevelSellerSignals test.: FAIL (Chrome: FAIL, Safari: FAIL)
    • browserSignals.dataVersion test.: FAIL (Chrome: FAIL, Safari: FAIL)
    • browserSignals.modifiedBid test.: FAIL (Chrome: FAIL, Safari: FAIL)
    • browserSignals.highestScoringOtherBid with no other interest groups test.: FAIL (Chrome: FAIL, Safari: FAIL)
    • browserSignals.highestScoringOtherBid with other groups that do not bid.: FAIL (Chrome: FAIL, Safari: FAIL)
    • browserSignals.highestScoringOtherBid with other bids.: FAIL (Chrome: FAIL, Safari: FAIL)
    • browserSignals.interestGroupName test.: FAIL (Chrome: FAIL, Safari: FAIL)
    • browserSignals.madeHighestScoringOtherBid with no other bids.: FAIL (Chrome: FAIL, Safari: FAIL)
    • browserSignals.madeHighestScoringOtherBid with group that did not bid.: FAIL (Chrome: FAIL, Safari: FAIL)
    • browserSignals.madeHighestScoringOtherBid with other bid.: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fledge/tentative/send-report-to.https.sub.window.html [wpt.fyi]
    • Both send reports, seller passes nothing to bidder.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Only seller sends a report: FAIL (Chrome: FAIL, Safari: FAIL)
    • Only seller sends a report, bidder throws an exception: FAIL (Chrome: FAIL, Safari: FAIL)
    • Only seller sends a report, bidder has no reportWin() method: FAIL (Chrome: FAIL, Safari: FAIL)
    • Only bidder sends a report: FAIL (Chrome: FAIL, Safari: FAIL)
    • Only bidder sends a report, seller passes a message to bidder: FAIL (Chrome: FAIL, Safari: FAIL)
    • Only bidder sends a report, seller throws an exception: FAIL (Chrome: FAIL, Safari: FAIL)
    • Only bidder sends a report, seller has no reportResult() method: FAIL (Chrome: FAIL, Safari: FAIL)
    • Seller calls sendReportTo() twice, which throws an exception.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Bidder calls sendReportTo() twice, which throws an exception.: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fledge/tentative/trusted-bidding-signals.https.sub.window.html [wpt.fyi]
    • No trustedBiddingSignalsKeys or trustedBiddingSignalsUrl.: FAIL (Chrome: FAIL, Safari: FAIL)
    • trustedBiddingSignalsKeys but no trustedBiddingSignalsUrl.: FAIL (Chrome: FAIL, Safari: FAIL)
    • trustedBiddingSignalsUrl without trustedBiddingSignalsKeys.: FAIL (Chrome: FAIL, Safari: FAIL)
    • trustedBiddingSignalsUrl closes the connection without sending anything.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response is HTTP 404 error.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response has no content-type.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response has wrong content-type.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response does not allow fledge.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response has wrong X-Allow-FLEDGE header.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response has no X-Allow-FLEDGE header.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response has no body.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response is not JSON.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response is a JSON array.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response in invalid JSON object.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response has no keys object.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response has no keys.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response keys is incorrectly an array.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response has key not in trustedBiddingSignalsKeys.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response null value for key.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response has a number value for key.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response has string value for key.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response has array value for key.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response has object value for key.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals receives empty string key.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response has multiple keys.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals receives escaped key.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals receives null key.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals receives interest group name.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals receives escaped interest group name.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals receives empty interest group name.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals receives hostname field.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response has no data-version.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response has numeric Data-Version.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response has min Data-Version.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response has max Data-Version.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response has too large Data-Version.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response has Data-Version with leading 0.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response has negative Data-Version.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response has decimal in Data-Version.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response has space in Data-Version.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response has hex Data-Version.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response has Data-Version and no trustedBiddingSignalsKeys.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response with Data-Version and empty body.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response with Data-Version and JSON array body.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response with Data-Version and double JSON object body.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted bidding signals response with Data-Version and invalid keys entry: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by ctuns@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/e0cac8c4f70c [wpt PR 41295] - Revert "Add WPT to test rounding for adCost", a=testonly

https://hg.mozilla.org/mozilla-central/rev/e0cac8c4f70c

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox118: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in before you can comment on or make changes to this bug.