1846833 - [wpt-sync] Sync PR 41296 - Make beginLayer a no-op if the filter parsing throws an exception.

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 41296 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41296
Details from upstream follow.

Jean-Philippe Gravel <[e-mail]> wrote:

Make beginLayer a no-op if the filter parsing throws an exception.

Bug: 1396372
Change-Id: I55cdddb7227a136428fe859ec8bfa25821d6f2cf
Reviewed-on: https://chromium-review.googlesource.com/4743183
WPT-Export-Revision: f7ee02b2a0ee780c93072ae015bc6f6289787524

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4ab8c514d08088ced213c21779f097b6a1f33fe

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 3 tests and 1 subtests

Status Summary

Firefox

OK : 3
FAIL: 3

Chrome

OK : 3
FAIL: 3

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/canvas/element/layers/2d.layer.exceptions-are-no-op.html [wpt.fyi]
  • Checks that the context state is left unchanged if beginLayer throws.: FAIL (Chrome: FAIL)
• /html/canvas/offscreen/layers/2d.layer.exceptions-are-no-op.html [wpt.fyi]
  • Checks that the context state is left unchanged if beginLayer throws.: FAIL (Chrome: FAIL)
• /html/canvas/offscreen/layers/2d.layer.exceptions-are-no-op.worker.html [wpt.fyi]
  • Checks that the context state is left unchanged if beginLayer throws.: FAIL (Chrome: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/525cec0a07bc
[wpt PR 41296] - Make beginLayer a no-op if the filter parsing throws an exception., a=testonly
https://hg.mozilla.org/integration/autoland/rev/b5f9ff0705dd
[wpt PR 41296] - Update wpt metadata, a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/525cec0a07bc
https://hg.mozilla.org/mozilla-central/rev/b5f9ff0705dd