Closed Bug 1846840 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 41298 - [FedCM] Tentatively fix flakiness in fedcm-iframe test

Categories

(Core :: DOM: Credential Management, task, P4)

task

Tracking

()

RESOLVED FIXED
118 Branch
Tracking Status
firefox118 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 41298 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41298
Details from upstream follow.

Nicolás Peña <npm@chromium.org> wrote:

[FedCM] Tentatively fix flakiness in fedcm-iframe test

The cancelHelper is not scoped accurately. Additionally, use a WeakPtr
for the RFH in case a test accidentally invokes the function after the
RFH is destroyed, to avoid UAF.

Bug: 1404951
Change-Id: I67c2259692b90a936cfeb3e268b839e1912879af

Reviewed-on: https://chromium-review.googlesource.com/4742921
WPT-Export-Revision: 0fef0226517749f8132556e2deccad3a03ba4d59

PR 41298 applied with additional changes from upstream: 2afbdfce6650cd57c5648e6ab5718241b175109a
Component: web-platform-tests → DOM: Credential Management
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 4 subtests

Status Summary

Firefox

OK : 1
PASS : 3
FAIL : 1

Chrome

PASS : 1
TIMEOUT: 2
NOTRUN : 2

Safari

OK : 1
FAIL : 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by ctuns@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/c8e367d79303 [wpt PR 41298] - [FedCM] Tentatively fix flakiness in fedcm-iframe test, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in before you can comment on or make changes to this bug.