1846847 - [wpt-sync] Sync PR 41301 - [FedCM] Don't omit schemes when formatting URLs

Status: RESOLVED FIXED

(Core :: DOM: Credential Management, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 41301 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41301
Details from upstream follow.

Christian Biesinger <[e-mail]> wrote:

[FedCM] Don't omit schemes when formatting URLs

We use the result of this function to construct a GURL, so
we can't omit any schemes.

In practice, this affects http: right now, but this patch also ensures
that the "omit https" and "omit file" bits are also not set to be
more futureproof.

R=[e-mail]

Bug: 1468681
Change-Id: Idac394102133f030dad899e9017fb5e3f0cb4b77
Reviewed-on: https://chromium-review.googlesource.com/4742567
WPT-Export-Revision: 705c6dc22e3a3e989ab60fe9217d917d8943d7c5

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=96b8694ab33612a76252d2218f6b11b1c20dc430

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 5 subtests

Status Summary

Firefox

OK : 1
PASS : 3
FAIL : 2

Chrome

PASS : 1
TIMEOUT: 2
NOTRUN : 3

Safari

FAIL : 4
TIMEOUT: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /credential-management/fedcm-iframe.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: TIMEOUT, Safari: TIMEOUT)
  • FedCM enabled in 2 level deep nested iframe. FedCM should be enabled regardless of iframe nesting depth: FAIL (Chrome: TIMEOUT, Safari: FAIL)
  • FedCM should work in non-HTTPS URLs on localhost: FAIL (Chrome: NOTRUN, Safari: TIMEOUT)

Tests Disabled in Gecko Infrastructure

• /credential-management/fedcm-iframe.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: TIMEOUT, Safari: TIMEOUT)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/df065b8c2df4
[wpt PR 41301] - [FedCM] Don't omit schemes when formatting URLs, a=testonly

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/df065b8c2df4