1846850 - remove mozilla-added IsGUIThread asserts from libwebrtc

Status: RESOLVED FIXED

(Core :: WebRTC, task, P2)

Description

[Michael Froman [:mjf]]

These files have added RTC_DCHECK(IsGUIThread(false)) lines from Bug 1060738.
modules/desktop_capture/mouse_cursor_monitor_win.cc
modules/desktop_capture/win/screen_capture_utils.cc
modules/desktop_capture/win/screen_capturer_win_gdi.cc

Checking crash stats over the past 6 months (here) for the methods containing these asserts doesn't show any crashes for those asserts.

We should be safe to stop carrying these modifications to libwebrtc.

Comment 1

[Michael Froman [:mjf]]

Attachment: Bug 1846850 - remove mozilla-added IsGUIThread asserts from libwebrtc. r?ng!

These were added in Bug 1060738 but no longer seem to add value based
on crash stats.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e6f94c1b7c4
remove mozilla-added IsGUIThread asserts from libwebrtc. r=ng,webrtc-reviewers

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/5e6f94c1b7c4