1846873 - Video fails to play on old.reddit.com (due to XHR errors?)

Status: RESOLVED DUPLICATE of bug 1846699

(Core :: DOM: File, defect)

Description

[Kevin Locke]

With current Firefox Nightly (build 20230802094513), (all?) videos fail to play on old.reddit.com. I bisected the regression to pushlog https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=bab9bf6052724188494b5dd1b3e64acf9f0f5b12&tochange=2d869f33d94695a46e6fd02f58b7abba6ac6dcf6 suggesting this was regressed by Bug 1784880. As a result, I noticed the Network tab shows multiple failed XHRs for mp4 URLs with NS_ERROR_NET_PARTIAL_TRANSFER which occur on 2d869f33d94695a46e6fd02f58b7abba6ac6dcf6, but not on bab9bf6052724188494b5dd1b3e64acf9f0f5b12. I'll attach the network log from each to aid debugging.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:twisniewski, since you are the author of the regressor, bug 1784880, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Kevin Locke]

I'll attach the network log from each to aid debugging.

On second thought, the .moz_log file for MOZ_LOG=timestamp,sync,nsHttp:5,cache2:5,nsSocketTransport:5,nsHostResolver:5 after playing (or trying to play) a second or two of video is >100MB. If this log would be helpful, I'll host it somewhere. Otherwise, let me know if more minimal logs would be useful.

Comment 3

[Thomas Wisniewski [:twisniewski]]

Ah, that's my patch indeed. I have a fix in the works, and if it doesn't fix a similar already-reported issue, I'll ask for a backout.

Comment 4

[Alice0775 White]

I can reproduce this on Nightly118.0a1 Windows10.

Comment 5

[Thomas Wisniewski [:twisniewski]]

I'm running a test here on a speculative fix: https://treeherder.mozilla.org/jobs?repo=try&revision=2618b74e81149011b36ed55d21a0241b970c6497

With luck we'll have confirmation within the next hour or two, and :dlrobertson has kindly offered to review that fix afterward if it does the trick.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1784880

Comment 7

[Dan Robertson (:dlrobertson)]

Tested with the fix for bug 1846699 merged, and I can no longer reproduce the issue