1846903 - [wpt-sync] Sync PR 41311 - [ComputePressure] Use AbortError for unobserve/disconnect method

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 41311 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41311
Details from upstream follow.

Wei4 Wang <[e-mail]> wrote:

[ComputePressure] Use AbortError for unobserve/disconnect method

According to the spec [1][2], pendingPromise should reject with an
AbortError when calling unobserve/disconnect method.

[1] https://www.w3.org/TR/compute-pressure/#the-unobserve-method
[2] https://www.w3.org/TR/compute-pressure/#the-disconnect-method

Bug: none
Change-Id: Icd83d62ae391738d883ba249d27a366673d48094
Reviewed-on: https://chromium-review.googlesource.com/4738336
WPT-Export-Revision: 7c65a4a350fa9f740de9f22c606426e125d53f1c

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9fb37523be60e38f18bce2b44c050b7aae5f2f7f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 9 tests and 2 subtests

Status Summary

Firefox

OK : 9
FAIL: 24

Chrome

OK : 9
FAIL: 24

Safari

OK : 9
FAIL: 24

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /compute-pressure/compute_pressure_basic.tentative.https.any.worker.html [wpt.fyi]
  • Return NotSupportedError when calling observer(): FAIL (Chrome: FAIL, Safari: FAIL)
  • Basic functionality test: FAIL (Chrome: FAIL, Safari: FAIL)
  • Removing observer before observe() resolves works: FAIL (Chrome: FAIL, Safari: FAIL)
  • Calling observe() multiple times works: FAIL (Chrome: FAIL, Safari: FAIL)
  • Starting a new observer after an observer has started works: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_basic.tentative.https.any.html [wpt.fyi]
  • Return NotSupportedError when calling observer(): FAIL (Chrome: FAIL, Safari: FAIL)
  • Basic functionality test: FAIL (Chrome: FAIL, Safari: FAIL)
  • Removing observer before observe() resolves works: FAIL (Chrome: FAIL, Safari: FAIL)
  • Calling observe() multiple times works: FAIL (Chrome: FAIL, Safari: FAIL)
  • Starting a new observer after an observer has started works: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_basic.tentative.https.any.sharedworker.html [wpt.fyi]
  • Return NotSupportedError when calling observer(): FAIL (Chrome: FAIL, Safari: FAIL)
  • Basic functionality test: FAIL (Chrome: FAIL, Safari: FAIL)
  • Removing observer before observe() resolves works: FAIL (Chrome: FAIL, Safari: FAIL)
  • Calling observe() multiple times works: FAIL (Chrome: FAIL, Safari: FAIL)
  • Starting a new observer after an observer has started works: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_disconnect_idempotent.tentative.https.any.html [wpt.fyi]
  • Stopped PressureObserver do not receive changes: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_disconnect_idempotent.tentative.https.any.sharedworker.html [wpt.fyi]
  • Stopped PressureObserver do not receive changes: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_disconnect_idempotent.tentative.https.any.worker.html [wpt.fyi]
  • Stopped PressureObserver do not receive changes: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_disconnect_immediately.tentative.https.any.html [wpt.fyi]
  • Stopped PressureObserver do not receive changes: FAIL (Chrome: FAIL, Safari: FAIL)
  • Removing observer before observe() resolves does not affect other observers: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_disconnect_immediately.tentative.https.any.sharedworker.html [wpt.fyi]
  • Stopped PressureObserver do not receive changes: FAIL (Chrome: FAIL, Safari: FAIL)
  • Removing observer before observe() resolves does not affect other observers: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_disconnect_immediately.tentative.https.any.worker.html [wpt.fyi]
  • Stopped PressureObserver do not receive changes: FAIL (Chrome: FAIL, Safari: FAIL)
  • Removing observer before observe() resolves does not affect other observers: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/94e6df83423d
[wpt PR 41311] - [ComputePressure] Use AbortError for unobserve/disconnect method, a=testonly

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/94e6df83423d