Closed Bug 1846978 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 41317 - Only add trailing border/padding to the right fragment, part 2.

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
118 Branch
Tracking Status
firefox118 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 41317 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41317
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

Only add trailing border/padding to the right fragment, part 2.

I tried to do this in CL:4345873, but that didn't cover all the cases.
If the node being laid out is a formatting context root, floats may also
play a role, so just looking for in-flow breaks inside isn't sufficient
in such cases.

When printing, adding trailing border/padding incorrectly caused
monolithic overflow. If there was something tall monolithic inside as
well, we'd keep on breaking before it indefinitely, because the
monolithic overflow on the container provided a break opportunity.

Bug: 1468664
Change-Id: I0e0c8c47deba4ffa611157497bc639f3c268836f
Reviewed-on: https://chromium-review.googlesource.com/4746460
WPT-Export-Revision: 8d1d1840ec80e71306a509dd652245f467e0b5e7

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 1
FAIL: 1

Chrome

PASS: 1
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by ctuns@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/709ecabc2ce3 [wpt PR 41317] - Only add trailing border/padding to the right fragment, part 2., a=testonly https://hg.mozilla.org/mozilla-central/rev/23497ea19aaf [wpt PR 41317] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in before you can comment on or make changes to this bug.