Closed Bug 1847044 Opened 4 months ago Closed 4 months ago

Contexts returned by browsingContext.create should always have valid dimensions


(Remote Protocol :: WebDriver BiDi, defect, P1)



(firefox-esr102 unaffected, firefox-esr115 unaffected, firefox116 unaffected, firefox117 fixed, firefox118 fixed)

118 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox-esr115 --- unaffected
firefox116 --- unaffected
firefox117 --- fixed
firefox118 --- fixed


(Reporter: jdescottes, Assigned: jdescottes)


(Blocks 1 open bug)


(Whiteboard: [webdriver:m8][webdriver:relnote] )


(1 file, 1 obsolete file)

As seen with Bug 1843604, the contexts created by browsingContext.create are sometimes returned before their content window has an actual size.

Some of our wdspec tests attempt to measure the window size using script.evaluate and read incorrect values.

We should ensure that the content window of the new contexts have a valid size so that consumers can check the window size without having to wait for some additional event or arbitrary delay.

This prevents intermittent failure where measuring the content window size right after creating a tab could return incorrect values.

Depends on D185312

Severity: -- → S3
Points: --- → 2
Priority: -- → P1
Whiteboard: [webdriver:m8]
Attachment #9347197 - Attachment is obsolete: true
Blocks: 1847094
Pushed by
[bidi] Force a reflow on contexts created by browsingContext.create r=webdriver-reviewers,whimboo
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch

beta is still affected and it might be good to get this patch uplifted.

Comment on attachment 9347196 [details]
Bug 1847044 - [bidi] Force a reflow on contexts created by browsingContext.create

Beta/Release Uplift Approval Request

  • User impact if declined: fixes frequent intermittent failures
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): minor JS change in WebDriver BiDi implementation, no impact for regular users
  • String changes made/needed:
  • Is Android affected?: No
Attachment #9347196 - Flags: approval-mozilla-beta?

Comment on attachment 9347196 [details]
Bug 1847044 - [bidi] Force a reflow on contexts created by browsingContext.create

Approved for 117.0b4.

Attachment #9347196 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Whiteboard: [webdriver:m8] → [webdriver:m8] [webdriver:relnote]
Whiteboard: [webdriver:m8] [webdriver:relnote] → [webdriver:m8][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.