Contexts returned by browsingContext.create should always have valid dimensions
Categories
(Remote Protocol :: WebDriver BiDi, defect, P1)
Tracking
(firefox-esr102 unaffected, firefox-esr115 unaffected, firefox116 unaffected, firefox117 fixed, firefox118 fixed)
| Tracking | Status | |
|---|---|---|
| firefox-esr102 | --- | unaffected |
| firefox-esr115 | --- | unaffected |
| firefox116 | --- | unaffected |
| firefox117 | --- | fixed |
| firefox118 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
(Blocks 1 open bug)
Details
(Whiteboard: [webdriver:m8][webdriver:relnote] )
Attachments
(1 file, 1 obsolete file)
|
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
As seen with Bug 1843604, the contexts created by browsingContext.create are sometimes returned before their content window has an actual size.
Some of our wdspec tests attempt to measure the window size using script.evaluate and read incorrect values.
We should ensure that the content window of the new contexts have a valid size so that consumers can check the window size without having to wait for some additional event or arbitrary delay.
|
Assignee | |
Comment 1•11 months ago
|
||
This prevents intermittent failure where measuring the content window size right after creating a tab could return incorrect values.
|
|
Assignee | |
Comment 2•11 months ago
|
||
Depends on D185312
|
|
Assignee | |
Updated•11 months ago
|
|
||
Updated•11 months ago
|
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/918000df0800 [bidi] Force a reflow on contexts created by browsingContext.create r=webdriver-reviewers,whimboo
|
||
Comment 4•11 months ago
|
||
| bugherder | ||
|
||
Comment 5•11 months ago
|
||
beta is still affected and it might be good to get this patch uplifted.
|
|
Assignee | |
Comment 6•11 months ago
|
||
Comment on attachment 9347196 [details]
Bug 1847044 - [bidi] Force a reflow on contexts created by browsingContext.create
Beta/Release Uplift Approval Request
- User impact if declined: fixes frequent intermittent failures
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): minor JS change in WebDriver BiDi implementation, no impact for regular users
- String changes made/needed:
- Is Android affected?: No
|
||
Comment 7•11 months ago
|
||
Comment on attachment 9347196 [details]
Bug 1847044 - [bidi] Force a reflow on contexts created by browsingContext.create
Approved for 117.0b4.
|
|
||
Updated•11 months ago
|
|
|
Assignee | |
Updated•10 months ago
|
|
|
||
Updated•9 months ago
|
Description
•