1847114 - [wpt-sync] Sync PR 41330 - Make dialog user-agent styles apply while in top layer

Status: RESOLVED FIXED

(Core :: Layout: Positioned, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 41330 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41330
Details from upstream follow.

Joey Arhar <[e-mail]> wrote:

Make dialog user-agent styles apply while in top layer

This makes it so that while the dialog element is doing an exit
animation, its positioning etc. styles from the user-agent stylesheet
still apply so it doesnt jump to a different spot while animating out.
The :modal class is removed during this time which is why it was a
problem before. We also can't just make all dialog elements always have
these styles applied, because then they would also apply to non-modal
dialogs.

Spec: https://github.com/whatwg/html/pull/9387

Fixed: 1451910
Change-Id: I4d2b240ab17879d6cf08f94f32d7c7577e9f53ea

Reviewed-on: https://chromium-review.googlesource.com/4739784
WPT-Export-Revision: 23293b911418b963827d0d271e04a88f8a841d6f

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ddb412995d7becefad59d50627142057230d899b

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-position/overlay/overlay-transition-dialog.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b236b7633341
[wpt PR 41330] - Make dialog user-agent styles apply while in top layer, a=testonly
https://hg.mozilla.org/integration/autoland/rev/26b3da58419e
[wpt PR 41330] - Update wpt metadata, a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b236b7633341
https://hg.mozilla.org/mozilla-central/rev/26b3da58419e