184722 - macromedia.com - FSCommands not working with OBJECT tags

Status: RESOLVED INCOMPLETE

(Tech Evangelism Graveyard :: English US, defect, P2)

Description

[Peter Lubczynski]

You'll need Flash 6 with scriptability to test this bug. You can install the
version that comes with Netscape 7 by clicking here:
ftp://ftp.netscape.com/pub/netscape7/english/7.0/windows/win32/ewc9e/flash.xpi

This is from bug 183512. I'm having problems using FSCommands with the OBJECT
tag. Here are the two problems I am seeing:

1. Plugin does not seem to call into browser at all if the 'ID' attribute is
used instead of 'NAME'. If I add a 'NAME' attribute, at least I see the plugin
trying to call into the browser through GetURL.

2. If the call is made, the plugin uses the document.embeds[] array to attempt
to access its DOM node. However, this array only contains EMBED tags, not
OBJECTs, so the Javascript URL Flash uses to hook up 2-way scripting fails:

JavaScript error:
javascript: function jsScriptObject(obj) { this.wrappedJSObject = obj; }
jsScriptObject.prototype = { evaluate : function(expression) { return new
jsScriptObject(eval(expression)); } }; 
FAILS w/ OBJECT --->  var plugin = document.embeds['send_to_flash']; 
plugin.SetWindow(new jsScriptObject(window),1134180267); 
---->line 1: plugin has no properties



So I think Flash may need to be changed to use the more standards compliant
'getElementById' to access the DOM. However, we may be able to take a shot at
fixing this on our end. Here's the idea for the hack:

1. On OBJECT tags for Flash that have an ID attribute but not NAME, dynamically
copy the ID's value to a new NAME entry in the array of attributes/parameters we
pass the plugin in NPP_New.

2. We could add OBJECT tags tags to the document.embeds[] array such that the
script above would succeeded in getting the plugin. 
cc:ing jst for DOM impact on this change.

Comment 1

[Peter Lubczynski]

Attachment: testcase

Comment 2

[rubydoo123]

sooner rather than later

Comment 3

[rubydoo123]

reassign

Comment 4

[Peter Lubczynski]

--->evang

Comment 5

[Peter Lubczynski]

Attachment: old patch (wip)

Comment 6

[Bob Clary [:bc] (inactive)]

-> evang500

Comment 7

[Nick Bebout]

SPAM: New Components

Comment 8

[Josh Santangelo]

Not sure what the status on this is, but in Moz 1.3, fscommands seemed to work
fine, but in 1.4 final, this error is coming up:

Error: plugin.SetWindow is not a function
Source File: javascript: function jsScriptObject(obj) { this.wrappedJSObject =
obj; } jsScriptObject.prototype = { evaluate : function(expression) { return new
jsScriptObject(eval(expression)); } }; var plugin = document.embeds['topnav'];
plugin.SetWindow(new jsScriptObject(window),2063466735);
Line: 1

Comment 9

[Bob Clary [:bc] (inactive)]

This is still an issue with Shockwave Flash 7.0 r19

Comment 10

[Marcia Knous [:marcia]]

evang bug triage. Confirming bc's comment 9. Using FF 1.0 I get this in the JS
console: 
Error: window.document.get_var.SetVariable is not a function
Source File:
http://www.macromedia.com/support/flash/ts/documents/flash_to_flash_comm/flash_to_flash.htm
Line: 13

Marking for f/u

Comment 11

[Chris Lawson (gone)]

INCOMPLETE due to lack of activity since the end of 2009.

If someone is willing to investigate the issues raised in this bug to determine whether they still exist, *and* work with the site in question to fix any existing issues, please feel free to re-open and assign to yourself.

Sorry for the bugspam; filter on "NO MORE PRE-2010 TE BUGS" to remove.