Closed Bug 1847327 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 41348 - [sticky] Keep marking for layout if we've propagated objects.

Categories

(Core :: Layout: Positioned, task, P4)

task

Tracking

()

RESOLVED FIXED
118 Branch
Tracking Status
firefox118 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 41348 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41348
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[sticky] Keep marking for layout if we've propagated objects.

Now that we propagate LayoutObjects within the fragment tree - we could
encounter the situation where:

  • A subtree becomes display-locked.
  • An element is removed (which was propagated - like sticky).
  • We re-use a fragment due to a cache hit (contains an invalid
    layout-object).
  • Update sticky-constraints == boom.

This patch keeps invalidating the layout-tree for display-locked roots
if we end up in this situtation (which should be sufficiently rare).

Fixed: 1470149
Change-Id: I126ae9cd01892f8c9d137ffd688f51d964005682
Reviewed-on: https://chromium-review.googlesource.com/4753313
WPT-Export-Revision: 151ab9dfda34d22f0a97696c651238859646b89c

Component: web-platform-tests → Layout: Positioned
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b3ad86e4a194 [wpt PR 41348] - [sticky] Keep marking for layout if we've propagated objects., a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in before you can comment on or make changes to this bug.