1847500 - should check for presence of linux/videodev2.h before enabling V4L2 (or include the proper videoio.h header on NetBSD/OpenBSD)

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P5)

Description

[Landry Breuil (:gaston)]

on OpenBSD, we have a v4l2-compatible API for webcams etc, but so far no such things for accelerated decoding of videos (which afaict is also confusingly named 'v4l2') so since 116 firefox fails to build v4l2test on OpenBSD/arm64:

/usr/obj/ports/firefox-116.0/firefox-116.0/widget/gtk/v4l2test/v4l2test.cpp:12:10: fatal error: 'linux/videodev2.h' file not found

i think https://searchfox.org/mozilla-central/source/toolkit/moz.configure#545 should be amended to ensure that linux/videodev2.h exists. Or v4l2test.cpp shouldnt include this header if it doesnt exist.

Comment 1

[Landry Breuil (:gaston)]

or reuse the same #ifdef dance as used in webrtc, such as in https://searchfox.org/mozilla-central/source/third_party/libwebrtc/moz-patch-stack/0014.patch#26, which would also fix solaris:

+#if defined(__NetBSD__) || defined(__OpenBSD__) // WEBRTC_BSD
+#include <sys/videoio.h>
+#elif defined(__sun)
+#include <sys/videodev2.h>
+#else
 #include <linux/videodev2.h>
+#endif

Comment 2

[Landry Breuil (:gaston)]

Attachment: minimal test program building/working on OpenBSD

looking at v4l2test, there's no reason it shouldnt build on OpenBSD, according to http://bxr.su/OpenBSD/sys/sys/videoio.h#1418 the #defines used should exist for us if the right include is used.

not a patch, but the attached test program (adapted quickly from v4l2test.cpp) builds with a plain C compiler and runs on OpenBSD/amd64 (and properly says we dont have M2M support)

$./t -d /dev/video0
v4l2test probing device '/dev/video0'
v4l2test driver uvideo0 card Integrated Camera bus_info usb version 1
ERROR
V4L2 device /dev/video0 does not support M2M modes

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1839599

Comment 4

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Please create a patch for it and attach it here.
Thanks.

Comment 5

[Landry Breuil (:gaston)]

Attachment: Bug 1847500: include the proper v4l2 header on OpenBSD/NetBSD/solaris r?stransky

Comment 6

[Landry Breuil (:gaston)]

:petr, i dont know what is the status of m-c on solaris but you might be interested in the v4l2test patch at some point ?

Comment 7

[Petr Sumbera]

I don't know either. Right now we are focusing on basic Firefox functionality. I can just confirm that your change doesn't seem to cause any trauble.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef223d9e18ae
include the proper v4l2 header on OpenBSD/NetBSD/solaris r=stransky

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ef223d9e18ae