1847546 - Don't do duplicate work on style elements from the innerHTML setter.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1847546 - Don't do duplicate work on style elements from the innerHTML setter. r=hsivonen,smaug

Right now, when binding to the tree we queue a runnable to update the
stylesheet, even though mEnableUpdates is false.

Even though the redundant update is nowadays always cached, it's just
wasted work, and the code is simpler without it.

This will be tested by bug 1771113, which is what made me look at this.

We need to tweak a bit the dispatch of applicable state change events
for DevTools, because for a case like:

div.attachShadow({ mode: "open" }).innerHTML = <style>...</style>;

Before we'd go through the stylesheet cache here due to the redundant
update:

https://searchfox.org/mozilla-central/rev/fb43eb3bdf5b51000bc7dfe3474cbe56ca2ab63c/layout/style/SharedStyleSheetCache.cpp#161-165

But now we won't, and the code in StyleSheet.cpp wasn't quite correct /
didn't dispatch the event.

Nobody listens to style-sheet-applicable-state-changed, so remove that
code while at it.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1847546 - Clean-up nsHtml5TreeOperation::CreateHTMLElement. r=smaug,hsivonen

Couldn't resist.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9333c1c9a5e7
Don't do duplicate work on style elements from the innerHTML setter. r=smaug

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1847546 - Other misc nsHtml5TreeOperation clean-ups. r=smaug,hsivonen

Remove useless namespacing, we have an using statement in the file
anyways.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8444a955cd4a
Clean-up nsHtml5TreeOperation::CreateHTMLElement. r=smaug

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c085100a9a96
Other misc nsHtml5TreeOperation clean-ups. r=smaug

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/9333c1c9a5e7
https://hg.mozilla.org/mozilla-central/rev/8444a955cd4a
https://hg.mozilla.org/mozilla-central/rev/c085100a9a96