Closed
Bug 1847581
Opened 1 year ago
Closed 1 year ago
[wpt-sync] Sync PR 41365 - Fenced Frames: Add WPT checks for requestedSize API.
Categories
(Testing :: web-platform-tests, task, P4)
Testing
web-platform-tests
Tracking
(firefox118 fixed)
RESOLVED
FIXED
118 Branch
Tracking | Status | |
---|---|---|
firefox118 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Attachments
(1 file)
100.30 KB,
text/plain
|
Details |
Sync web-platform-tests PR 41365 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/41365
Details from upstream follow.
Andrew Verge <averge@chromium.org> wrote:
Fenced Frames: Add WPT checks for requestedSize API.
For all existing tests that pass requestedSize to the auctionConfig:
- A URL param with the same width and height from requestedSize is
passed in the bidding and decision logic URLs.- The serving code for both bidding and decision inserts requestedSize
checks in the returned Javascript.- Those checks confirm that the requestedSize in the browserSignals
(for bidding) or auctionConfig (for decision) have the same values as
the URL param. If the JS objects and the URL param don't match, an
error is thrown.With this method, we can confirm at runtime that the requestedSize is
plumbed through the browser correctly, because the generated Javascript
knows what the plumbed value is supposed to be.Change-Id: I36664db6e4a62c62e13dbcce86d78eabb8937b6b
Reviewed-on: https://chromium-review.googlesource.com/4756460
WPT-Export-Revision: 72e3d8daec151c90d1fc96f3e14ccab74564ebdd
Assignee | ||
Comment 1•1 year ago
|
||
PR 41365 applied with additional changes from upstream: 535a9abff0616c0d7f2b433f5aff0fd725ebc22b, 8f2f8e97d89c955dbe71f613502ccfb7345d741f
Assignee | ||
Updated•1 year ago
|
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Assignee | ||
Updated•1 year ago
|
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Assignee | ||
Comment 2•1 year ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c0ec8b135b5f777dfbbef176d822076002544bd
Assignee | ||
Comment 3•1 year ago
|
||
# CI Results
Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 184 tests and 1 subtests
## Status Summary
### Firefox
`OK` : 164[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 173[GitHub]
`PASS` : 16[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 17[GitHub]
`CRASH` : 1
`FAIL` : 408[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 481[GitHub]
`TIMEOUT`: 12[Gecko-windows11-32-2009-qr-debug] 13[Gecko-linux1804-64-qr-debug] 14[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub]
`ERROR` : 4[Gecko-windows11-64-2009-qr-debug] 5[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-opt, GitHub]
`NOTRUN` : 11[Gecko-windows11-32-2009-qr-debug] 14[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub]
### Chrome
`OK` : 173
`PASS` : 18
`FAIL` : 484
`TIMEOUT`: 14
`ERROR` : 5
`NOTRUN` : 10
### Safari
`OK` : 172
`PASS` : 16
`FAIL` : 480
`TIMEOUT`: 14
`ERROR` : 6
`NOTRUN` : 14
## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c0ec8b135b5f777dfbbef176d822076002544bd)
[GitHub PR Head](https://wpt.fyi/results/?sha=1a2a2e2e31938f96a126a1735a4d10d59ffd89ea&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=1a2a2e2e31938f96a126a1735a4d10d59ffd89ea&label=pr_base)
## Details
### Crashes
* [/fenced-frame/embedder-require-corp.https.html](https://wpt.live/fenced-frame/embedder-require-corp.https.html) [[wpt.fyi](https://wpt.fyi/results/fenced-frame/embedder-require-corp.https.html)]: `CRASH` [`Gecko-windows11-64-2009-qr-debug`], `ERROR` [`Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview`, `Gecko-android-em-7.0-x86_64-qr-debug-geckoview`, `Gecko-android-em-7.0-x86_64-qr-opt-geckoview`, `Gecko-linux1804-64-qr-debug`, `Gecko-linux1804-64-qr-opt`, `Gecko-windows11-32-2009-qr-debug`, `Gecko-windows11-32-2009-qr-opt`, `Gecko-windows11-64-2009-qr-opt`, `GitHub`] linked bug:Bug 1833103
* [/fenced-frame/sandbox-mandatory-flags.https.html](https://wpt.live/fenced-frame/sandbox-mandatory-flags.https.html) [[wpt.fyi](https://wpt.fyi/results/fenced-frame/sandbox-mandatory-flags.https.html)]: `CRASH` [`Gecko-linux1804-64-qr-debug`, `Gecko-windows11-32-2009-qr-debug`], `TIMEOUT` [`Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview`, `Gecko-android-em-7.0-x86_64-qr-debug-geckoview`, `Gecko-android-em-7.0-x86_64-qr-opt-geckoview`, `Gecko-linux1804-64-qr-opt`, `Gecko-windows11-32-2009-qr-opt`, `Gecko-windows11-64-2009-qr-debug`, `Gecko-windows11-64-2009-qr-opt`, `GitHub`] linked bug:Bug 1847365
(See attachment for full changes)
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0e6a18c52d03
[wpt PR 41365] - Fenced Frames: Add WPT checks for requestedSize API., a=testonly
Comment 5•1 year ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox118:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•