1847592 - Remove old migrations and move schema version to the history interface

Status: RESOLVED FIXED

(Toolkit :: Places, task, P3)

Description

[Marco Bonardo [:mak]]

This is clean up I noticed while working on another bug related to origins frecency, removing this allows me to skip some not strictly necessary changes.

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1847592 - Remove some old Places migrations and move schema version to the history service interface.

Since Firefox 72 was a watershed release, thus any upgrade of previous versions
must go through it, we can remove some old migrations.
We stop removing at Firefox 68, that was the last ESR before the watershed.

Also while there move the schema version to the history service so we don't have
to manually keep the migration test header in sync.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/201950bdeb03
Remove some old Places migrations and move schema version to the history service interface. r=places-reviewers,lina

Comment 3

[Iulian Moraru]

Backed out for causing xpcshell failures on test_missing_<something>.js.

• Push with failures

• Failure log for failures on test_missing_builtin_folders.js

• Failure log for failures on test_missing_root_folder.js

• Backout link

Comment 4

[Marco Bonardo [:mak]]

That test is likely using a very old db version...

Comment 5

[Marco Bonardo [:mak]]

Attachment: Bug 1847592 - Modify some Places tests to not rely on outdated versions of the database.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/089798a3947e
Remove some old Places migrations and move schema version to the history service interface. r=places-reviewers,lina
https://hg.mozilla.org/integration/autoland/rev/4d3a71169f8d
Modify some Places tests to not rely on outdated versions of the database. r=places-reviewers,lina

Comment 7

[Cristian Tuns]

Backed out for causing xpcshell failures in test_current_from_v53.js and test_places_replaceOnStartup_clone.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/maintenance/test_places_replaceOnStartup_clone.js | xpcshell return code: 0
• Failure Log2
• Failure line2: TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/migration/test_current_from_v53.js | database_is_valid - [database_is_valid : 9] 0 == 3

Comment 8

[Marco Bonardo [:mak]]

I wonder why Try didn't show these, and I could not see them locally. I guess I should just do a full rebase and Try run.
Edit: it was a binary patching problem, the places_v52.sqlite file ended up just being a renamed places_v43.sqlite

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fefe544eaaa1
Remove some old Places migrations and move schema version to the history service interface. r=places-reviewers,lina
https://hg.mozilla.org/integration/autoland/rev/5d075579fe14
Modify some Places tests to not rely on outdated versions of the database. r=places-reviewers,lina

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/fefe544eaaa1
https://hg.mozilla.org/mozilla-central/rev/5d075579fe14