1847600 - vsync keeps running if the shopping sidebar is hidden - should tell gecko when it's not needed/visible

Status: RESOLVED FIXED

(Firefox :: Shopping, defect, P3)

Description

[:Gijs (out for now; he/him)]

See bug 1847584.

This ends up happening when we're in the "loading" state and the sidebar is hidden.

For now, we should probably manually set docShellIsActive to false on the browsingcontexts that are hidden, and back to true when unhiding them. This also (it appears) applies to tab switches.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Setting P3 because there is no current assignee - but I suspect we should get to this sooner rather than later, as this cause unnecessary power usage.

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

:gijs, should this be a P1/P2 for 119?

Comment 3

[:Gijs (out for now; he/him)]

(In reply to Jared Hirsch [:jhirsch] (he/him) (Needinfo please) from comment #2)

:gijs, should this be a P1/P2 for 119?

I think this is WFM now bug 1847584 is fixed. It's possible we'd still benefit from setting isActive to false on sidebars in background tabs but I'm not sure if that's true. Emilio?

Comment 4

[Emilio Cobos Álvarez (:emilio)]

It's probably worth it.

Comment 5

[:Gijs (out for now; he/him)]

Attachment: Bug 1847600 - ensure shopping sidebar activeness updates when switching tabs or hiding/showing it, r?emilio!,fchasen!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0cab102319de
ensure shopping sidebar activeness updates when switching tabs or hiding/showing it, r=emilio,fchasen

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0cab102319de