1847609 - [wpt-sync] Sync PR 41341 - Don't reset global filter when entering layers.

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 41341 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41341
Details from upstream follow.

Jean-Philippe Gravel <[e-mail]> wrote:

Don't reset global filter when entering layers.

Layers should only reset states that are applied on the layer output, to
make sure that these states are not applied twice, once inside the layer
and once outside. The global filter however is not applied on the
filter's output so there is no reason to reset it in the layer.

Bug: 1396372

Change-Id: I13aea89ab159fd2fc0469fe1b62fa8bd5cf404a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4752234
Commit-Queue: Jean-Philippe Gravel \<[e-mail]>
Reviewed-by: Justin Novosad \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1180366}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d4a2fe3344dea0f0a59d64d92955d5de3e22f56

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

FAIL : 2
TIMEOUT: 1

Chrome

FAIL : 3

Safari

FAIL : 2
TIMEOUT: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/canvas/element/layers/2d.layer.global-filter.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/canvas/offscreen/layers/2d.layer.global-filter.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/canvas/offscreen/layers/2d.layer.global-filter.w.html [wpt.fyi]: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0239533bea8
[wpt PR 41341] - Don't reset global filter when entering layers., a=testonly
https://hg.mozilla.org/integration/autoland/rev/41d8a1fc4550
[wpt PR 41341] - Update wpt metadata, a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/f0239533bea8
https://hg.mozilla.org/mozilla-central/rev/41d8a1fc4550