1847640 - Users cannot clear their needinfo in a bug that's closed, if they lack editbugs

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Mathew Hodson]

There is an open needinfo for me in bug 1792458 but now that it's closed I cannot clear it. I suspect this would affect anyone that doesn't have editbugs permissions.

Comment 1

[Mathew Hodson]

Attachment: Screenshot of affected bug

This is all I see on bug 1792458, and I cannot clear the needinfo.

Comment 2

[David Lawrence [:dkl]]

(In reply to Mathew Hodson from comment #0)

There is an open needinfo for me in bug 1792458 but now that it's closed I cannot clear it. I suspect this would affect anyone that doesn't have editbugs permissions.

You are correct in that you need editbugs or be the reporter, assignee, or qa contact on the bug. I have cleared the needinfo for you.

Comment 3

[Mathew Hodson]

I think that this behaviour should be considered a bug with the way needinfo is handled on BMO. So I was hoping this could be used to track solving the problem at that level. It doesn't make sense that you wouldn't have permission to clear a needinfo for yourself.

Comment 4

[Daniel Holbert [:dholbert]]

(In reply to Mathew Hodson from comment #3)

I think that this behaviour should be considered a bug with the way needinfo is handled on BMO. So I was hoping this could be used to track solving the problem at that level. It doesn't make sense that you wouldn't have permission to clear a needinfo for yourself.

Agreed, we should fix that (or at least have a bug on file tracking that known-issue). --> reopening.

Unrelatedly: we should probably also grant you the editbugs permission. :) I've done that. Though also, happy to revert if you'd like to do further testing for e.g. this bug.

Comment 5

[David Lawrence [:dkl]]

I will update the code to allow commenting if the commenter is also a needinfo requestee.

Comment 6

[BMO Github Automation]

Attachment: [mozilla-bteam/bmo] Bug 1847640 - Users cannot clear their needinfo in a bug that's closed, if they lack editbugs (#2105)

Comment 7

[David Lawrence [:dkl]]

Merged
https://github.com/mozilla-bteam/bmo/commit/7921e4cb4e1aa79bdc283ac70f162b6f1ee3d15d

This change is now on production also.