1847646 - [wpt-sync] Sync PR 41371 - Add new tests for CanvasRenderingContext2D.reset()

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 41371 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41371
Details from upstream follow.

Kiet Ho <[e-mail]> wrote:

Add new tests for CanvasRenderingContext2D.reset()

I'm implementing CanvasRenderingContext2D.reset() in WebKit and I notice the only test for this method doesn't actually check if all drawing states are reset back to their default value, so I wrote new tests to check that.

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=efe18f2635d0c775d02be12b676bd5b0a334b703

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 89 tests and 1 subtests

Status Summary

Firefox

OK : 86
PASS: 80
FAIL: 9

Chrome

OK : 86
PASS: 83
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/canvas/element/reset/2d.reset.state.image_smoothing_quality.html [wpt.fyi]
  • check that the state is reset: FAIL (Chrome: PASS)
• /html/canvas/element/reset/2d.reset.state.line_dash.html [wpt.fyi]
  • check that the line dash is reset: FAIL (Chrome: FAIL)
• /html/canvas/element/reset/2d.reset.state.transformation_matrix.html [wpt.fyi]
  • check that the state is reset: FAIL (Chrome: FAIL)
• /html/canvas/offscreen/reset/2d.reset.state.image_smoothing_quality.html [wpt.fyi]
  • check that the state is reset: FAIL (Chrome: PASS)
• /html/canvas/offscreen/reset/2d.reset.state.image_smoothing_quality.worker.html [wpt.fyi]
  • check that the state is reset: FAIL (Chrome: PASS)
• /html/canvas/offscreen/reset/2d.reset.state.line_dash.html [wpt.fyi]
  • check that the line dash is reset: FAIL (Chrome: FAIL)
• /html/canvas/offscreen/reset/2d.reset.state.line_dash.worker.html [wpt.fyi]
  • check that the line dash is reset: FAIL (Chrome: FAIL)
• /html/canvas/offscreen/reset/2d.reset.state.transformation_matrix.html [wpt.fyi]
  • check that the state is reset: FAIL (Chrome: FAIL)
• /html/canvas/offscreen/reset/2d.reset.state.transformation_matrix.worker.html [wpt.fyi]
  • check that the state is reset: FAIL (Chrome: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fac7a2b2fad8
[wpt PR 41371] - Add new tests for CanvasRenderingContext2D.reset(), a=testonly
https://hg.mozilla.org/integration/autoland/rev/aac71a67a36f
[wpt PR 41371] - Update wpt metadata, a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/fac7a2b2fad8
https://hg.mozilla.org/mozilla-central/rev/aac71a67a36f