1847659 - Use the new MimeType parser to parse content-types for response headers

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Thomas Wisniewski [:twisniewski]]

We should be able to pass the mimesniff/mime-types/charset-parameter.window.html WPTs if we use our new MIMEType parser here:

• https://searchfox.org/mozilla-central/source/netwerk/protocol/http/nsHttpResponseHead.cpp#625

We could also pass a lot of the other MimeSniff tests by using it for blob content types, but unfortunately those tests conflict with the File spec (because the File spec expects blobs to only be lowercased and rejected if they have non-ASCII characters, while the MimeSniffing spec seems to expect them to be normalized, as if parsed and then serialized).

Comment 1

[Valentin Gosu [:valentin] (he/him)]

https://searchfox.org/mozilla-central/rev/8b470bef89879d6c9248e183562f77fd8da9b926/netwerk/protocol/http/nsHttpResponseHead.cpp#634

net_ParseContentType(val, mContentType, mContentCharset, &dummy);

We need to do something like this:
https://searchfox.org/mozilla-central/rev/503938c13ef2dd174705dc0f6d0683ae43074ccc/netwerk/protocol/data/nsDataHandler.cpp#187-194

if (mozilla::UniquePtr<CMimeType> parsed = CMimeType::Parse(mimeType)) {
  parsed->GetFullType(aContentType);
  if (aContentCharset) {
    parsed->GetParameterValue(kCharset, *aContentCharset);
  }
  if (aMimeType) {
    parsed->Serialize(*aMimeType);
  }

Comment 2

[Thomas Wisniewski [:twisniewski]]

Note that I actually have a patch in the works here already, but there were still try-failures I haven't accounted for: https://treeherder.mozilla.org/jobs?repo=try&revision=356a369dc72bbecb6f0a525ad7c2dca464a33f27

Comment 3

[Dylan]

Attachment: Bug 1847659 - Use the new MimeType parser to parse content-types for response headers; r?kershaw

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/433e82386c67
Use the new MimeType parser to parse content-types for response headers; r=kershaw,necko-reviewers

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out changeset 433e82386c67 (Bug 1847659) for causing failures in script.window.html CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=DpWkaXvTT7yyg8QZUMQ_Zg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=433e82386c67d75129933c61174453099debe3f3

Log: https://treeherder.mozilla.org/logviewer?job_id=441064175&repo=autoland&lineNumber=17113

Backout: https://hg.mozilla.org/integration/autoland/rev/eaabad4dd002ccbc4b5b3ec02071512d09b7f22c

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b4cc6e72a48
Use the new MimeType parser to parse content-types for response headers; r=kershaw,necko-reviewers

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8b4cc6e72a48