1847758 - pre-calculate length and hash for dom::PinnedStringId::init

Status: RESOLVED DUPLICATE of bug 1850344

(Core :: DOM: Bindings (WebIDL), task, P3)

Description

[Tooru Fujisawa [:arai]]

https://searchfox.org/mozilla-central/rev/e4d8451468be3a0f8a9faa3d37cadf07200821ec/dom/bindings/PinnedStringId.h#24,30-31

class PinnedStringId {
...
  bool init(JSContext* cx, const char* string) {
    JSString* str = JS_AtomizeAndPinString(cx, string);

the consumer of PinnedStringId::init is auto-generated from webidl, and the length and the hash can be pre-calculated either in the bindgen or compile-time.

https://searchfox.org/mozilla-central/source/__GENERATED__/dom/bindings/APZTestDataBinding.cpp#935-936,942-943

bool
APZBucket::InitIds(JSContext* cx, APZBucketAtoms* atomsCache)
...
  if (!atomsCache->sequenceNumber_id.init(cx, "sequenceNumber") ||
      !atomsCache->scrollFrames_id.init(cx, "scrollFrames")) {

Comment 1

[Tooru Fujisawa [:arai]]

this might become unnecessary if we can extend the well-known atoms with gecko atoms in bug 1848278.

Comment 2

[Tooru Fujisawa [:arai]]

This will be handled as part of bug 1850344, by merging them into extended-known atoms.