Closed Bug 1847784 Opened 2 years ago Closed 2 years ago

Implement the DarkTheme UX for FedCM prompts

Categories

(GeckoView :: General, task, P1)

Firefox 118
All
Android
task

Tracking

(firefox119 verified)

VERIFIED FIXED
119 Branch
Tracking Status
firefox119 --- verified

People

(Reporter: titouan, Assigned: titouan)

References

(Blocks 1 open bug)

Details

(Whiteboard: [foundation][fxdroid] )

Attachments

(1 file)

No description provided.
Assignee: nobody → tthibaud
Priority: -- → P1
Severity: -- → N/A

Authored by Titouan Thibaud
https://github.com/mozilla-mobile/firefox-android/commit/06ba878f2f7296c6b3bb139af814ca696806ae9c
[main] Bug 1847784: Provide a Theme to FedCM Provider Dialogs

Status: NEW → RESOLVED
Closed: 2 years ago
Flags: qe-verify+
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch

How to test:

Preparation

I recommend to first open those two links in any browser (it doesnt need to be on the testing device), because they are hosted on a machine that enters sleep mode after a few minutes without use and takes some time to wake up:

Testing

On Fenix on the test device:

  • Open about:config
  • Search for the key dom.security.credentialmanagement.identity.enabled, and set it to true
  • Open https://grand-military-astrodon.glitch.me/
  • login with username titouan and any password (it doesn't matter on this demo website)
  • scroll down and click on "VISIT THE RP TO TRY FEDCM"

Expected:

  • a first dialog appears to chose the Identity Provider. "Demo IDP" is the only option, Chose it.
  • a second dialog appears, to chose the Account "Titouan Lastname"
  • a third dialog, accept the Policy
  • you should be redirected to the "Signed in" page, showing the account name and picture.

The flow should be tested in Dark Mode and Light Mode.
To test it in another mode, you enable/disable Dark Mode on your device, and then just log out from the RP website. The Dialogs flow should be shown again.

Note
The Policy Dialog (the policy one) is shown only once for each account. If you want to see it again, you can either login with another account on the IDP website (just input a different username with anypassword, and then update the name, surname and picture if you want) or clear the Fenix data

Attached video Dark_Mode.mp4

Thank you, Titouan, for the detailed STR, this is really helpful.
Verified fixed on the latest Nightly 120.0a1 from 09/29 with Samsung Galaxy A53 5G (Android 13). The prompts are correctly displayed in Light Mode and in Dark Mode.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: