Closed Bug 1847794 Opened 10 months ago Closed 9 months ago

Ensure the Search component's browser mochitests and XPCShell tests use add_setup correctly

Categories

(Firefox :: Search, task, P2)

task

Tracking

()

RESOLVED FIXED
119 Branch
Tracking Status
firefox119 --- fixed

People

(Reporter: scunnane, Assigned: scunnane)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Some of the search browser Mochitests and many of the search XPCShell tests put test setup code inside an add_task call, rather than an add_setup call. There are at least 2 reasons this isn't a good idea:

  1. add_setup is more explicit and semantically correct
  2. When adding an .only() call to a task to run that task in isolation, the setup code will not be run at all if it's inside an add_task call, whereas it would be run if it were inside an add_setup call.
Type: defect → task
Summary: Ensure the Search component browser mochitests and XPCShell tests → Ensure the Search component's browser mochitests and XPCShell tests use add_setup correctly
Pushed by scunnane@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0339e9d43c22
Ensure the Search component's browser mochitests and XPCShell tests use add_setup correctly. r=search-reviewers,daleharvey
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
Severity: S4 → --
See Also: → 1854456
Blocks: 1776576
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: