1847794 - Ensure the Search component's browser mochitests and XPCShell tests use add_setup correctly

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Stephanie Cunnane [:scunnane]]

Some of the search browser Mochitests and many of the search XPCShell tests put test setup code inside an add_task call, rather than an add_setup call. There are at least 2 reasons this isn't a good idea:

1. add_setup is more explicit and semantically correct
2. When adding an .only() call to a task to run that task in isolation, the setup code will not be run at all if it's inside an add_task call, whereas it would be run if it were inside an add_setup call.

Comment 1

[Stephanie Cunnane [:scunnane]]

Attachment: Bug 1847794 - Ensure the Search component's browser mochitests and XPCShell tests use add_setup correctly. r?#search-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0339e9d43c22
Ensure the Search component's browser mochitests and XPCShell tests use add_setup correctly. r=search-reviewers,daleharvey

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/0339e9d43c22