Closed
Bug 1847794
Opened 9 months ago
Closed 8 months ago
Ensure the Search component's browser mochitests and XPCShell tests use add_setup correctly
Categories
(Firefox :: Search, task, P2)
Firefox
Search
Tracking
()
RESOLVED
FIXED
119 Branch
| Tracking | Status | |
|---|---|---|
| firefox119 | --- | fixed |
People
(Reporter: scunnane, Assigned: scunnane)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Some of the search browser Mochitests and many of the search XPCShell tests put test setup code inside an add_task call, rather than an add_setup call. There are at least 2 reasons this isn't a good idea:
add_setupis more explicit and semantically correct- When adding an
.only()call to a task to run that task in isolation, the setup code will not be run at all if it's inside anadd_taskcall, whereas it would be run if it were inside anadd_setupcall.
|
Assignee | |
Updated•9 months ago
|
Type: defect → task
Summary: Ensure the Search component browser mochitests and XPCShell tests → Ensure the Search component's browser mochitests and XPCShell tests use add_setup correctly
|
|
Assignee | |
Comment 1•8 months ago
|
||
Pushed by scunnane@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0339e9d43c22 Ensure the Search component's browser mochitests and XPCShell tests use add_setup correctly. r=search-reviewers,daleharvey
|
||
Comment 3•8 months ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 months ago
status-firefox119:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
|
|
Assignee | |
Updated•7 months ago
|
Severity: S4 → --
You need to log in
before you can comment on or make changes to this bug.
Description
•