remove aec logging output size limiting code
Categories
(Core :: WebRTC, task, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox118 | --- | fixed |
People
(Reporter: mjf, Assigned: mjf)
References
Details
Attachments
(4 files)
Upstream has changed file names from aec_* to aec3_* so our "largest file" detection is no longer working here. Additionally, there does seem to be a "aec3_near" as an easy replacement. We'll need to choose a new file for this purpose.
Assignee | ||
Comment 1•1 year ago
|
||
The list of candidate files:
-rw-r--r--@ 1 mfroman staff 1011712 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_E2_4-0.dat
-rw-r--r--@ 1 mfroman staff 1011712 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_N2_4-0.dat
-rw-r--r--@ 1 mfroman staff 1011712 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_R2_4-0.dat
-rw-r--r--@ 1 mfroman staff 1011712 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_S2_linear_4-0.dat
-rw-r--r--@ 1 mfroman staff 1011712 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_X2_4-0.dat
-rw-r--r--@ 1 mfroman staff 1011712 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_Y2_4-0.dat
-rw-r--r--@ 1 mfroman staff 4096 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_active_render_4-0.dat
-rw-r--r--@ 1 mfroman staff 4096 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_all_filters_diverged_4-0.dat
-rw-r--r--@ 1 mfroman staff 4096 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_any_coarse_filter_converged_4-0.dat
-rw-r--r--@ 1 mfroman staff 4096 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_any_filter_consistent_4-0.dat
-rw-r--r--@ 1 mfroman staff 4096 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_any_filter_converged_4-0.dat
-rw-r--r--@ 1 mfroman staff 12288 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_call_order_4-0.dat
-rw-r--r--@ 1 mfroman staff 2985984 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_capture_analyze_input_4-0.wav
-rw-r--r--@ 1 mfroman staff 245760 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_capture_decimator_output_4-0.wav
-rw-r--r--@ 1 mfroman staff 995328 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_capture_input_4-0.wav
-rw-r--r--@ 1 mfroman staff 995328 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_capture_output_4-0.wav
-rw-r--r--@ 1 mfroman staff 12288 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_capture_saturation_4-0.dat
-rw-r--r--@ 1 mfroman staff 995328 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_coarse_filter_output_4-0.wav
-rw-r--r--@ 1 mfroman staff 7970816 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_correlator_0_h_4-0.dat
-rw-r--r--@ 1 mfroman staff 7970816 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_correlator_1_h_4-0.dat
-rw-r--r--@ 1 mfroman staff 7970816 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_correlator_2_h_4-0.dat
-rw-r--r--@ 1 mfroman staff 7970816 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_correlator_3_h_4-0.dat
-rw-r--r--@ 1 mfroman staff 7970816 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_correlator_4_h_4-0.dat
-rw-r--r--@ 1 mfroman staff 1990656 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_correlator_error_0_h_4-0.dat
-rw-r--r--@ 1 mfroman staff 1990656 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_correlator_error_1_h_4-0.dat
-rw-r--r--@ 1 mfroman staff 1990656 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_correlator_error_2_h_4-0.dat
-rw-r--r--@ 1 mfroman staff 1990656 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_correlator_error_3_h_4-0.dat
-rw-r--r--@ 1 mfroman staff 1990656 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_correlator_error_4_h_4-0.dat
-rw-r--r--@ 1 mfroman staff 28672 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_correlator_lag_0_4-0.dat
-rw-r--r--@ 1 mfroman staff 28672 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_correlator_lag_1_4-0.dat
-rw-r--r--@ 1 mfroman staff 28672 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_correlator_lag_2_4-0.dat
-rw-r--r--@ 1 mfroman staff 28672 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_correlator_lag_3_4-0.dat
-rw-r--r--@ 1 mfroman staff 28672 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_correlator_lag_4_4-0.dat
-rw-r--r--@ 1 mfroman staff 28672 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_correlator_pre_echo_lag_0_4-0.dat
-rw-r--r--@ 1 mfroman staff 28672 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_correlator_pre_echo_lag_1_4-0.dat
-rw-r--r--@ 1 mfroman staff 28672 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_correlator_pre_echo_lag_2_4-0.dat
-rw-r--r--@ 1 mfroman staff 28672 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_correlator_pre_echo_lag_3_4-0.dat
-rw-r--r--@ 1 mfroman staff 28672 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_correlator_pre_echo_lag_4_4-0.dat
-rw-r--r--@ 1 mfroman staff 4096 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_dominant_nearend_4-0.dat
-rw-r--r--@ 1 mfroman staff 995328 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_echo_estimate_4-0.wav
-rw-r--r--@ 1 mfroman staff 12288 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_echo_path_delay_estimator_delay_4-0.dat
-rw-r--r--@ 1 mfroman staff 995328 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_echo_remover_capture_input_4-0.dat
-rw-r--r--@ 1 mfroman staff 995328 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_echo_remover_capture_input_4-0.wav
-rw-r--r--@ 1 mfroman staff 995328 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_echo_remover_render_input_4-0.dat
-rw-r--r--@ 1 mfroman staff 995328 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_echo_remover_render_input_4-0.wav
-rw-r--r--@ 1 mfroman staff 4096 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_echo_saturation_4-0.dat
-rw-r--r--@ 1 mfroman staff 61440 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_er_acum_numerator_4-0.dat
-rw-r--r--@ 1 mfroman staff 1011712 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_erl_4-0.dat
-rw-r--r--@ 1 mfroman staff 12288 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_erl_time_domain_4-0.dat
-rw-r--r--@ 1 mfroman staff 1011712 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_erle_4-0.dat
-rw-r--r--@ 1 mfroman staff 12288 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_erle_instantaneous_quality_4-0.dat
-rw-r--r--@ 1 mfroman staff 1011712 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_erle_onset_4-0.dat
-rw-r--r--@ 1 mfroman staff 1011712 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_erle_onset_compensated_4-0.dat
-rw-r--r--@ 1 mfroman staff 4096 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_excess_render_detected_4-0.dat
-rw-r--r--@ 1 mfroman staff 12288 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_external_delay_avaliable_4-0.dat
-rw-r--r--@ 1 mfroman staff 12288 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_filter_delay_4-0.dat
-rw-r--r--@ 1 mfroman staff 1011712 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_filter_tail_freq_resp_est_4-0.dat
-rw-r--r--@ 1 mfroman staff 12288 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_fullband_erle_inst_log2_4-0.dat
-rw-r--r--@ 1 mfroman staff 12288 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_fullband_erle_log2_4-0.dat
-rw-r--r--@ 1 mfroman staff 12288 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_fullband_erle_max_log2_4-0.dat
-rw-r--r--@ 1 mfroman staff 12288 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_fullband_erle_min_log2_4-0.dat
-rw-r--r--@ 1 mfroman staff 4096 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_initial_state_4-0.dat
-rw-r--r--@ 1 mfroman staff 12288 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_inv_misadjustment_factor_4-0.dat
-rw-r--r--@ 1 mfroman staff 12288 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_late_reverb_end_4-0.dat
-rw-r--r--@ 1 mfroman staff 12288 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_late_reverb_start_4-0.dat
-rw-r--r--@ 1 mfroman staff 28672 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_latency_blocks_4-0.dat
-rw-r--r--@ 1 mfroman staff 11956224 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_linear_filter_processed_td_4-0.dat
-rw-r--r--@ 1 mfroman staff 28672 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_min_latency_blocks_4-0.dat
-rw-r--r--@ 1 mfroman staff 12288 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_narrow_render_4-0.dat
-rw-r--r--@ 1 mfroman staff 12288 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_num_reverb_decay_blocks_4-0.dat
-rw-r--r--@ 1 mfroman staff 995328 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_output_4-0.dat
-rw-r--r--@ 1 mfroman staff 995328 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_output_4-0.wav
-rw-r--r--@ 1 mfroman staff 995328 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_output_linear2_4-0.wav
-rw-r--r--@ 1 mfroman staff 995328 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_output_linear_4-0.wav
-rw-r--r--@ 1 mfroman staff 28672 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_processblock_call_order_4-0.dat
-rw-r--r--@ 1 mfroman staff 995328 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_processblock_capture_input2_4-0.wav
-rw-r--r--@ 1 mfroman staff 995328 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_processblock_capture_input_4-0.wav
-rw-r--r--@ 1 mfroman staff 995328 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_processblock_render_input_4-0.wav
-rw-r--r--@ 1 mfroman staff 995328 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_refined_filters_output_4-0.wav
-rw-r--r--@ 1 mfroman staff 1011712 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_refined_gain_H_error_4-0.dat
-rw-r--r--@ 1 mfroman staff 245760 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_render_decimator_output_4-0.wav
-rw-r--r--@ 1 mfroman staff 28672 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_render_delay_controller_buffer_delay_4-0.dat
-rw-r--r--@ 1 mfroman staff 28672 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_render_delay_controller_delay_4-0.dat
-rw-r--r--@ 1 mfroman staff 995328 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_render_input_4-0.wav
-rw-r--r--@ 1 mfroman staff 12288 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_reverb_alpha_4-0.dat
-rw-r--r--@ 1 mfroman staff 12288 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_reverb_decay_4-0.dat
-rw-r--r--@ 1 mfroman staff 12288 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_reverb_tail_energy_4-0.dat
-rw-r--r--@ 1 mfroman staff 2023424 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_subtractor_G_coarse_4-0.dat
-rw-r--r--@ 1 mfroman staff 2023424 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_subtractor_G_refined_4-0.dat
-rw-r--r--@ 1 mfroman staff 12288 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_subtractor_e2_coarse_4-0.dat
-rw-r--r--@ 1 mfroman staff 12288 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_subtractor_e2_refined_4-0.dat
-rw-r--r--@ 1 mfroman staff 26312704 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_subtractor_h_coarse_4-0.dat
-rw-r--r--@ 1 mfroman staff 26312704 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_subtractor_h_refined_4-0.dat
-rw-r--r--@ 1 mfroman staff 12288 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_subtractor_y2_4-0.dat
-rw-r--r--@ 1 mfroman staff 1011712 Aug 8 16:09 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_suppressor_gain_4-0.dat
-rw-r--r--@ 1 mfroman staff 4096 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_transparent_mode_4-0.dat
-rw-r--r--@ 1 mfroman staff 4096 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_usable_linear_estimate_4-0.dat
-rw-r--r--@ 1 mfroman staff 12288 Aug 8 16:08 /var/folders/qr/z33mn_gx73b0lfcxc_zfk6t00000gn/T/aec3_using_subtractor_output[0]_4-0.dat
Assignee | ||
Comment 2•1 year ago
|
||
Paul, can you help with choosing a better file to use?
Comment 3•1 year ago
|
||
What is this "largest file" business about? In any case I mostly care about the .wav
.
Updated•1 year ago
|
Assignee | ||
Comment 4•1 year ago
|
||
After a discussion with jesup and padenot on matrix, we've decided to remove this functionality. This will help with our patch-stack.
Assignee | ||
Comment 5•1 year ago
|
||
Assignee | ||
Comment 6•1 year ago
|
||
Depends on D185930
Assignee | ||
Comment 7•1 year ago
|
||
Depends on D185931
Assignee | ||
Comment 8•1 year ago
|
||
Depends on D185932
Comment 10•1 year ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7622e6dddeec
https://hg.mozilla.org/mozilla-central/rev/525d71640bb7
https://hg.mozilla.org/mozilla-central/rev/cf6e6b982db8
https://hg.mozilla.org/mozilla-central/rev/1b51359e2e51
Description
•