1847843 - [ppc64] third_party/highway/hwy/ops/ppc_vsx-inl.h:92:32: error: use of 'long long' with '__vector' requires VSX support (available on POWER7 or later) to be enabled

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect, P5)

Description

[Mike Hommey [:glandium]]

[task 2023-08-04T00:19:03.795Z] 00:19:03     INFO -  In file included from /builds/worker/checkouts/gecko/third_party/highway/hwy/contrib/image/image.cc:23:
[task 2023-08-04T00:19:03.795Z] 00:19:03     INFO -  In file included from /builds/worker/checkouts/gecko/third_party/highway/hwy/foreach_target.h:233:
[task 2023-08-04T00:19:03.795Z] 00:19:03     INFO -  In file included from /builds/worker/checkouts/gecko/third_party/highway/hwy/contrib/image/image.cc:24:
[task 2023-08-04T00:19:03.795Z] 00:19:03     INFO -  In file included from /builds/worker/checkouts/gecko/third_party/highway/hwy/highway.h:407:
[task 2023-08-04T00:19:03.795Z] 00:19:03    ERROR -  /builds/worker/checkouts/gecko/third_party/highway/hwy/ops/ppc_vsx-inl.h:92:32: error: use of 'long long' with '__vector' requires VSX support (available on POWER7 or later) to be enabled
[task 2023-08-04T00:19:03.795Z] 00:19:03     INFO -  HWY_VSX_RAW128(int64_t, signed long long, long long)     // NOLINT(runtime/int)
[task 2023-08-04T00:19:03.795Z] 00:19:03     INFO -                                 ^
[task 2023-08-04T00:19:03.795Z] 00:19:03    ERROR -  /builds/worker/checkouts/gecko/third_party/highway/hwy/ops/ppc_vsx-inl.h:92:43: error: use of 'long long' with '__vector' requires VSX support (available on POWER7 or later) to be enabled
[task 2023-08-04T00:19:03.795Z] 00:19:03     INFO -  HWY_VSX_RAW128(int64_t, signed long long, long long)     // NOLINT(runtime/int)
[task 2023-08-04T00:19:03.795Z] 00:19:03     INFO -                                            ^
[task 2023-08-04T00:19:03.795Z] 00:19:03    ERROR -  /builds/worker/checkouts/gecko/third_party/highway/hwy/ops/ppc_vsx-inl.h:93:35: error: use of 'long long' with '__vector' requires VSX support (available on POWER7 or later) to be enabled
[task 2023-08-04T00:19:03.795Z] 00:19:03     INFO -  HWY_VSX_RAW128(uint64_t, unsigned long long, long long)  // NOLINT(runtime/int)
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -                                    ^
[task 2023-08-04T00:19:03.796Z] 00:19:03    ERROR -  /builds/worker/checkouts/gecko/third_party/highway/hwy/ops/ppc_vsx-inl.h:93:46: error: use of 'long long' with '__vector' requires VSX support (available on POWER7 or later) to be enabled
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -  HWY_VSX_RAW128(uint64_t, unsigned long long, long long)  // NOLINT(runtime/int)
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -                                               ^
[task 2023-08-04T00:19:03.796Z] 00:19:03    ERROR -  /builds/worker/checkouts/gecko/third_party/highway/hwy/ops/ppc_vsx-inl.h:95:24: error: use of 'double' with '__vector' requires VSX support to be enabled (available on POWER7 or later)
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -  HWY_VSX_RAW128(double, double, long long)  // NOLINT(runtime/int)
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -                         ^
[task 2023-08-04T00:19:03.796Z] 00:19:03    ERROR -  /builds/worker/checkouts/gecko/third_party/highway/hwy/ops/ppc_vsx-inl.h:95:32: error: use of 'long long' with '__vector' requires VSX support (available on POWER7 or later) to be enabled
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -  HWY_VSX_RAW128(double, double, long long)  // NOLINT(runtime/int)
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -                                 ^
[task 2023-08-04T00:19:03.796Z] 00:19:03    ERROR -  /builds/worker/checkouts/gecko/third_party/highway/hwy/ops/ppc_vsx-inl.h:664:44: error: call to 'vec_splats' is ambiguous
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -    return Vec128<int64_t, N>{vec_sra(v.raw, vec_splats(63ULL))};
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -                                             ^~~~~~~~~~
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -  /builds/worker/fetches/clang/lib/clang/16/include/altivec.h:14706:51: note: candidate function
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -  static __inline__ vector signed char __ATTRS_o_ai vec_splats(signed char __a) {
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -                                                    ^
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -  /builds/worker/fetches/clang/lib/clang/16/include/altivec.h:14711:1: note: candidate function
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -  vec_splats(unsigned char __a) {
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -  ^
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -  /builds/worker/fetches/clang/lib/clang/16/include/altivec.h:14715:45: note: candidate function
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -  static __inline__ vector short __ATTRS_o_ai vec_splats(short __a) {
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -                                              ^
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -  /builds/worker/fetches/clang/lib/clang/16/include/altivec.h:14720:1: note: candidate function
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -  vec_splats(unsigned short __a) {
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -  ^
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -  /builds/worker/fetches/clang/lib/clang/16/include/altivec.h:14724:43: note: candidate function
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -  static __inline__ vector int __ATTRS_o_ai vec_splats(int __a) {
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -                                            ^
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -  /builds/worker/fetches/clang/lib/clang/16/include/altivec.h:14729:1: note: candidate function
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -  vec_splats(unsigned int __a) {
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -  ^
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -  /builds/worker/fetches/clang/lib/clang/16/include/altivec.h:14763:45: note: candidate function
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -  static __inline__ vector float __ATTRS_o_ai vec_splats(float __a) {
[task 2023-08-04T00:19:03.796Z] 00:19:03     INFO -                                              ^

This was fixed upstream in https://github.com/google/highway/commit/9139120cfc83a7e474c49506faeb89be66e6f52a

Comment 1

[Ashley Hale [:ahale]]

NI - this looks like an easy thing to patch in from the above, and it looks like it's image related, do you want to take this?

Comment 2

[Timothy Nikkel (:tnikkel)]

We have update bot setup for this library that will do regular automatic updates of this library. So unless there is a pressing need to update this quicker than that cadence I would be inclined to let the regular auto update process take care of this.

Comment 3

[Kelsey Gilbert [:jgilbert]]

How often does it update? When should we expect it?

Comment 4

[Timothy Nikkel (:tnikkel)]

I'm not sure what triggers an update to be generated but there have been about ten libjxl update bugs this year, the last one being July 24, so I'd guess we could expect another one before the end of August.

Comment 5

[Timothy Nikkel (:tnikkel)]

This should hopefully be fixed now.

Comment 6

[Mike Hommey [:glandium]]

Looks like so.