1847845 - [ppc64] sha512-p8.o: ABI version 2 is not compatible with ABI version 1 output

Status: RESOLVED FIXED

(NSS :: Build, defect)

Description

[Mike Hommey [:glandium]]

Building Firefox for ppc64 (big-endian) fails with:

[task 2023-08-04T06:48:39.482Z] 06:48:39     INFO -  /builds/worker/fetches/binutils/bin/ld.bfd: /builds/worker/workspace/obj-build/security/nss/lib/freebl/freebl_freeblpriv3/../freebl_gcm-aes-ppc_c_lib/sha512-p8.o: ABI version 2 is not compatible with ABI version 1 output
[task 2023-08-04T06:48:39.482Z] 06:48:39     INFO -  /builds/worker/fetches/binutils/bin/ld.bfd: failed to merge target specific data of file /builds/worker/workspace/obj-build/security/nss/lib/freebl/freebl_freeblpriv3/../freebl_gcm-aes-ppc_c_lib/sha512-p8.o

This is because the gyp config doesn't check anything about the ABI in use, contrary to the equivalent Makefile:
https://searchfox.org/nss/rev/a9928ea43c27da7a25476c07a60fe4779b44f81a/lib/freebl/Makefile#307-309
vs.
https://searchfox.org/nss/rev/a9928ea43c27da7a25476c07a60fe4779b44f81a/lib/freebl/freebl.gyp#290-294

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1847845 - Transpose the PPC_ABI check from Makefile to gyp.

Comment 2

[Mike Hommey [:glandium]]

cf. https://phabricator.services.mozilla.com/D185738#inline-1033217

Comment 3

[Mike Hommey [:glandium]]

https://hg.mozilla.org/projects/nss/rev/484ef4cd29784b033529bda8227743e0bc93e705