Open Bug 1847866 Opened 1 year ago Updated 1 year ago

Remove overlapping of the the moz-message-bars in addon-card in about:addons

Categories

(Toolkit :: Add-ons Manager, task, P5)

task

Tracking

()

UNCONFIRMED

People

(Reporter: annhermy, Unassigned)

References

Details

Attachments

(1 file)

When both .update-postponed-bar and .addon-card-message moz-message-bars are visible in the addon-card, they are overlapping a little (4px). To fix this we can change margin-top here.
But we also have to set border-radius of the upper moz-message-bar .update-postponed-bar to zero when the .addon-card-message is visible.
As soon as :has() pseudo class will be implemented (Bug 418039) we can add this rule to aboutaddons.css to set that border-radius: .update-postponed-bar:has(~ .addon-card-message:not([hidden])) {border-radius: 0;}

Depends on: has-pseudo

Hey Mark, I'm thinking that this followup may belong to the "Toolkit :: Addon Manager" bugzilla component more than to the "Toolkit :: XUL Widgets" one, but wanted to ask you before moving it in our bugzilla component.

If you agree and the fix to be applied to aboutaddons.css as also mentioned in comment 0, then feel free to move it into our component (but I'm also happy to take care of moving it if you prefer).

Flags: needinfo?(mstriemer)

This seems like it's more related to the Add-ons Manager styling. It would be good to move the negative margin on those moz-message-bars to a container element, which should simplify positioning them. Then the remaining issue would be the border radius, which should be solvable with a .addon.card moz-message-bar:last-of-type selector, but we'd need to remove/add the element as its needed

Component: XUL Widgets → Add-ons Manager
Flags: needinfo?(mstriemer)
Severity: -- → N/A
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: