1847989 - Fix Profiles with OPFS entries that already upgraded from <=115 to 116

Status: VERIFIED FIXED

(Core :: DOM: File, defect, P1)

Description

[Dianna Smith [:diannaS]]

In bug 1847619 we will be correcting an issue that occurs when Firefox users of Adobe Photoshop online upgrade from <=Fx115 to 116(the bug prevented them from accessing old or creating new files).

This ticket is to address the profiles that were already affected.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Assigning to Jan, since he's best situated to do this

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1847989 - Fix Profiles with OPFS entries that already upgraded from <=115 to 116; r=#dom-storage

Comment 3

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2024-10-06)]

Should we mark bug 1847619 as dup of this? (Dianna says no)

Comment 4

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2024-10-06)]

QA test steps

Prerequisites

• Install mozregression by pip install mozregression
• Get an Adobe subscription

Getting 115 profile

1. Run mozregression --repo mozilla-release --launch 115.0.3 --arg https://creativecloud.adobe.com/photoshop --profile-persistence reuse --profile (profiledir) (set your own profile folder in --profile)
2. Sign in to Photoshop https://creativecloud.adobe.com/photoshop
3. Create a document
   1. Select some example task, in my case I selected "Make BW background"
   2. Select some example photo, in my case I selected "jumping man"
   3. Remember not to edit this photo, just in case doing so changes the behavior
4. Create another document by repeating the previous step, this time to edit freely
5. Close Firefox
6. Backup the profile

Getting 116 profile, a broken one

1. Prepare 115 profile from the backup
2. Run mozregression --repo mozilla-release --launch 116.0.1 --arg https://creativecloud.adobe.com/photoshop --profile-persistence reuse --profile (profiledir) (use the directory of the previous step)
3. Open all documents created during 115 profile preparation
4. Open devtools and see whether it says 'worker sent an error' or 'Could not open "jumping-man"', while the loading indicator in the webpage never finishes
5. Close Firefox after confirming the message on each tab
6. Backup the profile

Testing

Repeat the following with your backed up 115 and 116 profile.

1. Run firefox --profile (profiledir) https://creativecloud.adobe.com/photoshop with your build including the fix
2. Open all documents created during 115
3. Confirm the load completes and you can click brush button on the left
4. Try drawing by the brush on the edit-free photo and saving it by Control+S or equivalent
5. Try reloading and confirm the load still completes
6. Try closing Firefox and reload and confirm it still completes
7. Try clearing data from adobe.com in "Cookies and Site Data"➡️"Manage Data..." in about:preferences#privacy and reload and confirm it still completes

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27aeca3e79ca
Fix Profiles with OPFS entries that already upgraded from <=115 to 116; r=dom-storage-reviewers,jesup

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 9348496 [details]
Bug 1847989 - Fix Profiles with OPFS entries that already upgraded from <=115 to 116; r=#dom-storage

Beta/Release Uplift Approval Request

• User impact if declined: OPFS users (especially Photoshop) will continue to be broken if they access an image cached locally in 115.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See bug
  Engineers have tested local builds. Adobe has been sent Try builds to test.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Worst case would be it's still broken but in a different way, or not fixing everyone. Clear Site Data should resolve things in all cases. It's not a one-liner patch, but the problem is well-understood, and JanV answered my questions in detail about what the patch does, why, what happens that causes the DB corruption and attempts to use the corrupted DB.
  Analysis of the bug is that this patch is unlikely to cause problems or dataloss for non-Adobe users (and they're likely broken now too, if they had OPFS data in 115)
  Android is affected, but photoshop doesn't work (well?) on android. Other OPFS users will, though.
  We do not have good automated tests for upgrades, so this will rely on manual testing. We can file followups for better general DB upgrade tests in the future.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 7

[Dianna Smith [:diannaS]]

Comment on attachment 9348496 [details]
Bug 1847989 - Fix Profiles with OPFS entries that already upgraded from <=115 to 116; r=#dom-storage

Approved for 116.0.3 dot release

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/d74d85238ec3

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/e62bf69c57f2

Comment 10

[Donal Meehan [:dmeehan]]

Comment on attachment 9348496 [details]
Bug 1847989 - Fix Profiles with OPFS entries that already upgraded from <=115 to 116; r=#dom-storage

Approved for 117.0b7

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/27aeca3e79ca

Comment 12

[Jan Varga [:janv]]

It seems an additional fix is needed.

Comment 13

[Jan Varga [:janv]]

Attachment: Bug 1847989 - Clear only invalid file ids and invalid main files during the additional upgrade for version 2; r=#dom-storage

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7081c01a8f31
Clear only invalid file ids and invalid main files during the additional upgrade for version 2; r=dom-storage-reviewers,jesup

Comment 15

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7081c01a8f31

Comment 16

[Tracy Walker [:tracy]]

Verified fixed on latest Nightly
Name Firefox
Version 118.0a1
Build ID 20230815091726

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/ea32c3ece390

Comment 18

[Dianna Smith [:diannaS]]

Comment on attachment 9348915 [details]
Bug 1847989 - Clear only invalid file ids and invalid main files during the additional upgrade for version 2; r=#dom-storage

Approved for 117.0b8
Approved for dot release 116.0.3 build 2

Comment 19

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/834ccf07973b

Comment 20

[Bogdan Maris, Desktop Test Engineering]

I also verified that this is now fixed on both Firefox 116.0.3-build2 and Firefox 117.0b8 across platforms (Windows 10, macOS 13 and Ubuntu 18.04). No extra issues found while testing.

Comment 21

[Jens Stutte [:jstutte]]

Please be aware that we need to fix also bug 1848916 to have a complete solution.