Closed Bug 1848034 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 41400 - [FLEDGE] Fix scoring signals data-version tests.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox118 fixed)

Status:
RESOLVED FIXED
Milestone:
118 Branch
Tracking Flags:
Tracking Status
firefox118 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 41400 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41400
Details from upstream follow.

Matt Menke <mmenke@chromium.org> wrote:

[FLEDGE] Fix scoring signals data-version tests.

They were calling runTrustedScoringSignalsTest() instead of
runTrustedScoringSignalsDataVersionTest(). As a result, they were only
checking the data version received by scoreAd(), instead of checking it
in both scoreAd() and reportResult().

Also fix a bug in how runTrustedScoringSignalsTest() tracks reports.

Bug: 1425952
Change-Id: I61799da4ec1689b238424ddf3baf8fe42c425b06
Reviewed-on: https://chromium-review.googlesource.com/4764429
WPT-Export-Revision: f216cdd384cb24a07a4b2b3afc42b9e4e668ef5f

PR 41400 applied with additional changes from upstream: 7a48bbd4ed7425a3981f607d0f4ed2b7d9069b63

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 37 subtests

Status Summary

Firefox

OK : 1
FAIL: 37

Chrome

OK : 1
FAIL: 37

Safari

OK : 1
FAIL: 37

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /fledge/tentative/trusted-scoring-signals.https.sub.window.html [wpt.fyi]
    • No trustedScoringSignalsUrl.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals closes the connection without sending anything.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response is HTTP 404 error.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has no content-type.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has wrong content-type.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response does not allow FLEDGE.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has wrong Ad-Auction-Allowed header.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has no Ad-Auction-Allowed header.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has no body.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response is not JSON.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response is a JSON array.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response is invalid JSON object.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has no renderUrl object.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has no renderUrls.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has renderURL not in response.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has null value for renderURL.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has a number value for renderURL.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has a string value for renderURL.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has an array value for renderURL.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has an object value for renderURL.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals with escaped renderURL.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals receives hostname field.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals multiple renderURLs.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has no Data-Version.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has valid Data-Version.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has min Data-Version.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has max Data-Version.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has too large Data-Version.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has data-version with leading 0.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has negative Data-Version.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has decimal in Data-Version.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has space in Data-Version.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has hex Data-Version.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has data-version and empty body.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has data-version and JSON array body.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has data-version and double JSON object body.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Trusted scoring signals response has data-version and no renderURLs.: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f082ddef6214 [wpt PR 41400] - [FLEDGE] Fix scoring signals data-version tests., a=testonly https://hg.mozilla.org/integration/autoland/rev/9f6b9dcb0c0a [wpt PR 41400] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f082ddef6214
https://hg.mozilla.org/mozilla-central/rev/9f6b9dcb0c0a

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox118: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in before you can comment on or make changes to this bug.