1848045 - libwebrtc 4bc60452f7 adds ability to set output directory - remove mozilla-specific code to do same thing

Status: RESOLVED FIXED

(Core :: WebRTC, task, P2)

Description

[Michael Froman [:mjf]]

We don't need a mozilla-specific way to do this now that upstream has added the ability to set the output directory. This will help with our patch-stack.

Comment 1

[Michael Froman [:mjf]]

Attachment: Bug 1848045 - to upstream - fix misuse of rtc::strcpyn in ApmDataDumper::SetOutputDirectory. r?ng!

rtc::strcpyn second param should be the size of the destination buffer,
not the size of the source string. This has been masked because FormFileName
helpfully adds a trailing path separator if one is missing.

Comment 2

[Michael Froman [:mjf]]

Attachment: Bug 1848045 - removing mozilla output directory handling code from apm_data_dumper. r?ng!

Upstream added the capability to set the output directory in commit 4bc60452f7 so
we can revert to using upstream's version instead of ours.

Depends on D185862

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d935bb25734
to upstream - fix misuse of rtc::strcpyn in ApmDataDumper::SetOutputDirectory. r=ng,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/48217906ac98
removing mozilla output directory handling code from apm_data_dumper. r=ng,webrtc-reviewers

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/5d935bb25734
https://hg.mozilla.org/mozilla-central/rev/48217906ac98