Closed
Bug 1848045
Opened 1 year ago
Closed 1 year ago
libwebrtc 4bc60452f7 adds ability to set output directory - remove mozilla-specific code to do same thing
Categories
(Core :: WebRTC, task, P2)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
118 Branch
Tracking | Status | |
---|---|---|
firefox118 | --- | fixed |
People
(Reporter: mjf, Assigned: mjf)
Details
Attachments
(2 files)
We don't need a mozilla-specific way to do this now that upstream has added the ability to set the output directory. This will help with our patch-stack.
Assignee | ||
Updated•1 year ago
|
Assignee: nobody → mfroman
Severity: -- → S3
Priority: -- → P2
Assignee | ||
Comment 1•1 year ago
|
||
rtc::strcpyn second param should be the size of the destination buffer,
not the size of the source string. This has been masked because FormFileName
helpfully adds a trailing path separator if one is missing.
Assignee | ||
Comment 2•1 year ago
|
||
Upstream added the capability to set the output directory in commit 4bc60452f7 so
we can revert to using upstream's version instead of ours.
Depends on D185862
Pushed by mfroman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5d935bb25734
to upstream - fix misuse of rtc::strcpyn in ApmDataDumper::SetOutputDirectory. r=ng,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/48217906ac98
removing mozilla output directory handling code from apm_data_dumper. r=ng,webrtc-reviewers
Comment 4•1 year ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5d935bb25734
https://hg.mozilla.org/mozilla-central/rev/48217906ac98
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox118:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•