1848048 - Add a menu to dismiss trending results

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: WIP: Bug 1848048 - Add a result menu to trending results.

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Bug 1848048 - Add a result menu to disable trending results. r=dao

Comment 3

[Dale Harvey (:daleharvey)]

Comment on attachment 9350734 [details]
Bug 1848048 - Add a result menu to disable trending results. r=dao

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1. What questions will you answer with this data?

How many users dismiss viewing trending data

2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements? Some example responses:

To determine whether users find the feature useful

3. What alternative methods did you consider to answer these questions? Why were they not sufficient?

No alternative

4. Can current instrumentation answer these questions?

Nope

5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

<table>
<tr>
<td>Measurement Description</td>
<td>Data Collection Category</td>
<td>Tracking Bug #</td>
</tr>
<tr>
<td>urlbar.trending.block</td>
<td>Category 2</td>
<td>1848048</td>
</tr>
</table>

6. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.

This collection is documented in its definitions file Scalars.yaml

7. How long will this data be collected? Choose one of the following:

• I want to permanently monitor this data. Henry Moseti

8. What populations will you measure?

An experiment targetting release users in en-US

9. If this data collection is default on, what is the opt-out mechanism for users?

Standard telemetry opt out

10. Please provide a general description of how you will analyze this data.

Will count how many people disabled the feature vs used it.

11. Where do you intend to share the results of your analysis?

Future product decisions

12. Is there a third-party tool (i.e. not Glean or Telemetry) that you are proposing to use for this data collection? If so:

No

Comment 4

[Elise Richards]

Comment on attachment 9350734 [details]
Bug 1848048 - Add a result menu to disable trending results. r=dao

Data Review Form

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

   • Yes, through the Scalars.yaml file.

2. Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

   • Yes, through the normal telemetry opt-out mechanisms for the application.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

   • Yes, this a permanent annotation. Henry Moseti will be monitoring.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

   • Category 2 - interaction data

5. Is the data collection request for default-on or default-off?

   • Default-on.

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

   • No

7. Is the data collection covered by the existing Firefox privacy notice?

   • Yes

8. Does the data collection use a third-party collection tool? If yes, escalate to legal.

   • No

Result

data-review+

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4de0550fbd1
Add a result menu to disable trending results. r=dao,fluent-reviewers,settings-reviewers,flod,Gijs

Comment 6

[Dale Harvey (:daleharvey)]

[Tracking Requested - why for this release]:

Comment 7

[Dale Harvey (:daleharvey)]

Comment on attachment 9350734 [details]
Bug 1848048 - Add a result menu to disable trending results. r=dao

Beta/Release Uplift Approval Request

• User impact if declined: We would like to run an experiment with this feature on 118
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change is behind a preferences and there is QA planned immediately when landing
• String changes made/needed: N/A (untranslated strings)
• Is Android affected?: No

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b4de0550fbd1

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9350734 [details]
Bug 1848048 - Add a result menu to disable trending results. r=dao

Approved for 118.0b5, thanks.

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/8e8c0e1f4bcb

Comment 11

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/8e8c0e1f4bcb