Open Bug 1848055 Opened 2 years ago Updated 1 month ago

Refactor history so that history items are correctly updated in `HistoryFragmentState`

Categories

(Firefox for Android :: History, enhancement)

Product:
Firefox for Android
Component:
History
Platform:
All
Android
Type:
enhancement

Tracking

()

People

(Reporter: matt-tighe, Unassigned)

References

(Blocks 1 open bug)

Details

Currently, history items are collected from storage and dispatched directly to the HistoryView. This creates some friction, as the HistoryFragmentState does not include some vital information for the screen and it can be hard to reason about the source of truth.

Refactor this area such that history items are included in HistoryFragmentState. A couple suggestions for implementation:

  1. Collect updates from storage in HistoryStorageMiddleware and dispatch updates from there to the store.
  2. Collect updates from storage in HistoryFragment and dispatch updates from there.
  3. Create a Binding that collects updates from storage and dispatch updates from there.
Severity: -- → S3

Saw that this might be becoming active, so wanted to point out that the first suggestion from my original comment would be the way to go if we want to follow current best practices. That is:

Collect updates from storage in HistoryStorageMiddleware and dispatch updates from there to the store. would be my suggestion

You need to log in before you can comment on or make changes to this bug.