1848058 - Don't auto-enable sidebar toggle for users with CFR pref disabled

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Shane Hughes [:aminomancer]]

In bug 1846044 we added behavior for auto-enabling the sidebar up to 2 times per user. But this is effectively a contextual feature recommendation, so we want to respect user prefs pertaining to CFRs. If these prefs are disabled

browser.newtabpage.activity-stream.asrouter.userprefs.cfr.features

we should not auto-enable the sidebar toggle, as the user has signalled that they know what they're doing.

It remains to be decided if we should account for this in telemetry. We think a ping will need to fire in ShoppingSidebarManager recording that the shopping sidebar is going to show (or would show if user was enrolled). And that could include whether the global toggle is active or not. That doesn't tell us why the global toggle was active/inactive, so it wouldn't tell us how many users are not seeing the sidebar due to CFR pref values.

So we should discuss whether we also want to send some kind of auto-enable ping at startup, recording the outcome of the auto-enable logic and the reason for not auto-enabling. This could be extraneous, since the main analysis we're trying to conduct is on the difference between users who've actually seen the sidebar and users who would've seen the sidebar but didn't because they're in the control branch.

So, before we land a patch for this we should ask Daniel Berry to confirm if we need this information or not.

Comment 1

[hanna A]

Attachment: Bug 1848058 - Don't auto-enable sidebar toggle for users with CFR pref disabled

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dcf55687fbb1
Don't auto-enable sidebar toggle for users with CFR pref disabled r=omc-reviewers,aminomancer

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/dcf55687fbb1