Timeout multiplier for DEBUG and TSAN builds are too low and causing a lot of TEST-UNEXPECTED-TIMEOUT failures
Categories
(Testing :: web-platform-tests, defect, P1)
Tracking
(firefox-esr115 fixed, firefox118 fixed)
People
(Reporter: whimboo, Assigned: whimboo)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [webdriver:m8], [wptsync upstream])
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-esr115+
|
Details | Review |
As noticed while working on bug 1847578 the timeout multiplier for TSAN builds is equal to the one for ASAN builds. But at least on Linux the tests are running around twice that long.
To prove that I fetched the timings for all the tests and added them to this spreadsheet:
As such I would propose to increase TSAN multiplier by the factor of 2x for its current value of 4. This is also in the range of 5-15% slower rate as mentioned in the llvm docs.
|
Assignee | |
Comment 1•9 months ago
|
||
|
|
Assignee | |
Updated•9 months ago
|
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d8efed7abad1 [wptrunner] Increase timeout multiplier for TSAN builds from 4 to 8. r=jgraham
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41425 for changes under testing/web-platform/tests
|
||
Comment 4•9 months ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 5•9 months ago
|
||
The timeout multiplier for DEBUG builds has been increased as well to be 4 instead of 3 in all the cases.
| Comment hidden (Intermittent Failures Robot) |
Upstream PR merged by moz-wptsync-bot
|
|
Assignee | |
Updated•9 months ago
|
|
|
Assignee | |
Comment 8•6 months ago
|
||
Comment on attachment 9348378 [details]
Bug 1848121 - [wptrunner] Increase timeout multiplier for TSAN builds from 4 to 8.
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: Fixes a perma wdspec failure on the esr-115 branch.
- User impact if declined: None
- Fix Landed on Version: 118
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Just changes the wptrunner's multiplier value to allow TSAN jobs to run longer.
|
||
Comment 9•6 months ago
|
||
Comment on attachment 9348378 [details]
Bug 1848121 - [wptrunner] Increase timeout multiplier for TSAN builds from 4 to 8.
Technically test-only and not needing approval, but a=me for good measure.
|
||
Comment 10•6 months ago
|
||
| uplift | ||
https://hg.mozilla.org/releases/mozilla-esr115/rev/15b12fe4522e
|
|
||
Updated•6 months ago
|
Description
•