1848134 - [Crash] mozilla.components.support.base.android.UnboundHandlerException: You must bind the NotificationPermissionHandler to an activity

Status: RESOLVED FIXED

(Firefox for Android :: Crash Reporting, defect, P3)

Description

[Mira Lobontiu (Android QA)]

Attachment: Screenshot_20230810-120426.png

Steps to reproduce

1. On Fenix Nightly 118.0a1 from 8/10, load a webiste, then, in the same tab type about:crashparent, to trigger a crash of the app.

Expected behavior

The app crashes, and a notification is displayed for the user to have the option to report the crash, and re-open Fenix.

Actual behavior

The app crashes, but there is no notification. Going to about:crashes, a different crash signature is displayed aside from the one triggerred manually - as seen in the attached screenshot.
The log is:

f85462ea-4bd3-4fde-89be-82b537b98cea
mozilla.components.support.base.android.UnboundHandlerException: You must bind the NotificationPermissionHandler to an activity
----
mozilla.components.support.base.android.UnboundHandlerException: You must bind the NotificationPermissionHandler to an activity
 at mozilla.components.support.base.android.NotificationsDelegate.requestNotificationPermission(NotificationsDelegate.kt:118)
 at mozilla.components.support.base.android.NotificationsDelegate.notify$default(NotificationsDelegate.kt:73)
 at mozilla.components.lib.crash.CrashReporter.onCrash$lib_crash_release(CrashReporter.kt:408)
 at mozilla.components.lib.crash.handler.CrashHandlerService$handleCrashIntent$1.invokeSuspend(CrashHandlerService.kt:23)
 at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:9)
 at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:112)
 at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:4)
 at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:3)
 at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:96)
 Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@8a11f39, Dispatchers.IO]

Device information

• Firefox version: only on today's Fenix Nightly 118.0a1
• NOT reproducible on Fenix Beta 117.0b5, nor on RC 116.2.0
• Android device: Google Pixel 6 (Android 14)
• NOT reproducible on: Oppo Find X3 Lite (Android 11), nor on Sony Xperia Z5 Premium (Android 7.1.1)

Comment 1

[Mihai Adrian Carare [:mcarare]]

Note that this is not a standalone crash, but an error caused by trying to request permission to show the notification. It should be automatically fixed when a new flow for sending crash reports is in place.

Comment 2

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1848134 - Do not throw UnboundHandlerException for crash notifications when permission is not already granted.

We cannot request permissions without an activity started.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5cacdb321306
Do not throw UnboundHandlerException for crash notifications when permission is not already granted. r=android-reviewers,boek

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/5cacdb321306

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mcarare, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox133 to wontfix.

For more information, please visit BugBot documentation.