1848209 - Approval flags are not set properly when should be when new revisions are created and status is draft

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Phabricator Integration, defect)

Description

[David Lawrence [:dkl]]

Suhaib reported another approval flag not being set properly on bug 1846854

• D185765 was in Draft status when the approval flags are checked so the X status was used
• The feed code updates the status to needs-review after the approval flag check so we need to reorder.
• When the user on D185765 added an uplift request as a new change to the same revision, the feed code returned early after the uplift form values were processed so the approval flag check was not ran again which would have set the flag that time.

Possible fixes are:

• move the code that sets the status to request-review above the loop that modifies attachments
• do a second loop over the attachments and set the approval flags after the revision status has been fixed
• have the draft state to map to the ? flag status in the status map

The easiest fix is to make the flag ? when state is draft since most of the time the revision will go from draft to needs-review right after and will never go back to draft.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-bteam/bmo] Bug 1848209 - Approval flags are not set properly when should be when new revisions are created and status is draft (#2101)

Comment 2

[David Lawrence [:dkl]]

Merged
https://github.com/mozilla-bteam/bmo/commit/3b2cb664e91ae10d2a47458fb89dd4d5366e6a4a