1848223 - Consider adding application foreground/background to the labels used for the extensions.process_event Glean metric

Status: RESOLVED FIXED

(WebExtensions :: Android, task, P2)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

As part of the Glean metric counter tracking how often the extension process is being created or did crash (introduced from Bug 1830157) we would like to also capture if the application was in foreground or background, because the Android behavior related to killing processes is different for an application that is in the foreground vs. one that is in the background.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1848223 - Keep track if the application is in the foreground and propagate appIsForeground flag along with process crash event.

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1848223 - Include foreground/background state in the labels part of the Glean extensions.process_event metric.

Depends on D185950

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: bug1830157_request_processEvent_fgbg_labels.md

Comment 4

[Chris H-C :chutten]

Comment on attachment 9349608 [details]
bug1830157_request_processEvent_fgbg_labels.md

PRELIMINARY NOTES:

If you're using Glean for this collection, you might find ./mach data-review helpful for generating a data review request template.

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Luca Greco is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/952106dc2faf
Keep track if the application is in the foreground and propagate appIsForeground flag along with process crash event. r=zombie
https://hg.mozilla.org/integration/autoland/rev/08ac58c77065
Include foreground/background state in the labels part of the Glean extensions.process_event metric. r=zombie

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures in toolkit/components/extensions/test/xpcshell/test_process_crash_telemetry.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/9451de3148827dbd587f22175b6c0453c7a605db

Push with failures

Failure log -> toolkit/components/extensions/test/xpcshell/test_process_crash_telemetry.js | test_process_crash_telemetry - [test_process_crash_telemetry : 96] Expect glean processEvent.crashed_bg to be set on Android builds - false == true

Comment 7

[Natalia Csoregi [:nataliaCs]]

Backout merged to mozilla-central: https://hg.mozilla.org/mozilla-central/rev/9451de3148827dbd587f22175b6c0453c7a605db

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9cf901ac3ee
Keep track if the application is in the foreground and propagate appIsForeground flag along with process crash event. r=zombie,willdurand
https://hg.mozilla.org/integration/autoland/rev/f95c18989fd2
Include foreground/background state in the labels part of the Glean extensions.process_event metric. r=zombie

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a9cf901ac3ee
https://hg.mozilla.org/mozilla-central/rev/f95c18989fd2

Comment 10

[William Durand [:willdurand]]

Comment on attachment 9348470 [details]
Bug 1848223 - Include foreground/background state in the labels part of the Glean extensions.process_event metric.

Beta/Release Uplift Approval Request

• User impact if declined: None? This is going to be used for an experiment on Android. These two patches + Bug 1848426 will allow us to enable the extensions process on Android using a Nimbus experiment/rollout. We'd like to have this in 118 to have more testing/monitoring time with a slow rollout.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1848426 (which should be uplifted first)
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's low risk because nothing will be enabled by default. These patches don't do much on Desktop because the extensions process (already enabled on Desktop) doesn't crash very often under normal circumstances. This is a bit different on Android but that's why it is disabled by default and we'll want to use a Nimbus experiment/rollout to make sure everything is working well.

In addition, we verified manually that these patches were fine on Nightly (Desktop and Fenix).

• String changes made/needed:
• Is Android affected?: Yes

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/7260e07aa801
https://hg.mozilla.org/releases/mozilla-beta/rev/3dc5e484725c

Comment 12

[Donal Meehan [:dmeehan]]

Comment on attachment 9348469 [details]
Bug 1848223 - Keep track if the application is in the foreground and propagate appIsForeground flag along with process crash event.

Approved for Desktop and Android 118.0b4

Comment 13

[Donal Meehan [:dmeehan]]

Comment on attachment 9348470 [details]
Bug 1848223 - Include foreground/background state in the labels part of the Glean extensions.process_event metric.

Approved for Desktop and Android 118.0b4