1848369 - Add checksum to Stencil XDR content

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Tooru Fujisawa [:arai]]

in order to detect disk or in-memory data corruption in more case, it's better adding checksum to Stencil XDR content itself, regardless of whether the container has it or not.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1848369 - Add checksum to Stencil XDR content. r?nbp!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21d4799cb89f
Add checksum to Stencil XDR content. r=nbp

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/21d4799cb89f

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1848369 - Add checksum to Stencil XDR content. r?nbp!

Original Revision: https://phabricator.services.mozilla.com/D186025

Comment 5

[Tooru Fujisawa [:arai]]

Comment on attachment 9348608 [details]
Bug 1848369 - Add checksum to Stencil XDR content. r?nbp!

Beta/Release Uplift Approval Request

• User impact if declined: Possible tab crash when data corruption happens in the bytecode cache , either on memory or on disk (bug 1848152)
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This avoid release assertion failure and turns the issue into runtime error. the runtime error path is already tested by regular syntax error in large file.
• String changes made/needed:
• Is Android affected?: Yes

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: crash volume is slightly high (bug 1848152)
• User impact if declined: Possible tab crash when data corruption happens in the bytecode cache , either on memory or on disk (bug 1848152)
• Fix Landed on Version: 118
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This avoid release assertion failure and turns the issue into runtime error. the runtime error path is already tested by regular syntax error in large file.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9348608 [details]
Bug 1848369 - Add checksum to Stencil XDR content. r?nbp!

Approved for 117.0b7. I don't think this needs to ride along in a dot release, however.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9348608 [details]
Bug 1848369 - Add checksum to Stencil XDR content. r?nbp!

Actually, this needs rebasing for Beta uplift. Please attach a rebased patch for ESR115 also before re-requesting approval.

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1848369 - Add checksum to Stencil XDR content. r?nbp!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9348792 [details]
Bug 1848369 - Add checksum to Stencil XDR content. r?nbp!

Approved for 117.0b8 and 115.2esr.

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/526a6be43363

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/9c1bbdbb0a37

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Backed out from ESR115 for bustage. Looks like we'll need a revised patch.
https://hg.mozilla.org/releases/mozilla-esr115/rev/9e618ea2666411eff37933840c0724429b5ecc69

https://treeherder.mozilla.org/logviewer?job_id=426069102&repo=mozilla-esr115&lineNumber=23756

Comment 13

[Tooru Fujisawa [:arai]]

Attachment: Bug 1848369 - Add checksum to Stencil XDR content. r?nbp!

Comment 14

[Tooru Fujisawa [:arai]]

Comment on attachment 9349085 [details]
Bug 1848369 - Add checksum to Stencil XDR content. r?nbp!

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration:
• User impact if declined:
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9349085 [details]
Bug 1848369 - Add checksum to Stencil XDR content. r?nbp!

Approved for 115.2esr.

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/5fb03c6b6af5