1848371 - Allow common fluent attributes without data-l10n-attrs

Status: RESOLVED WONTFIX

(Toolkit :: UI Widgets, defect)

Description

[Mark Striemer [:mstriemer]]

Related to bug 1848365, we expect to have some common fluent attributes that widgets will set. It's kind of annoying to set data-l10n-attrs="heading, message" so it would be nice to have this be allowed by default to our moz- custom elements

We could potentially do this in MozLitElement's connectedCallback() but it might be nicer to do this in the Fluent code itself

It seems unclear which attributes are allowed for our HTML custom elements there. It looks like label and aria-label may only be allowed for XUL elements. These are also useful for our HTML custom elements and should be allowed by default

Allow attributes: label, aria-label, heading, message, description

Comment 1

[Tim Giles [:tgiles]]

Is this now a dupe of Bug 1901336? Or is this bug more concerned with the ergonomics when declaring/using our reusable components? For example in firefoxview.html where data-l10n-attrs is being explicitly declared:

 <moz-page-nav
      data-l10n-id="firefoxview-page-heading"
      data-l10n-attrs="heading"
    >

Comment 2

[Mark Striemer [:mstriemer]]

Not quite a dupe but I think that solution makes having some safe-listed attributes irrelevant since it's so easy to do now

Closing as WONTFIX since I don't think we need to muddy the fluent code for this anymore