1848372 - [wpt-sync] Sync PR 41426 - Add tolerance to snapport covered computation

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 41426 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41426
Details from upstream follow.

David Awogbemila <[e-mail]> wrote:

Add tolerance to snapport covered computation

The layout code stores the compositor scroll nodes' bounds are ints
(gfx::Size) which may be rounded up or down. Rounded up values create an
issue because the snap code (which stores the snap area rects as floats)
might fail to recognize that a snap area covers the snap port due to the
round up.

This patch addresses this issue by allowing a 0.5 tolerance in the snap
code to account for possible rounding differences.

More details at [1]
[1] https://docs.google.com/document/d/126FGFTDkoOXSlYw6fQip_6F5o6E6WiEc7ZM7g9oPgdM

Bug: 1468412
Change-Id: If8d6c6f4f45ecf0b02bccb8ca731b0407cb77743
Reviewed-on: https://chromium-review.googlesource.com/4774422
WPT-Export-Revision: da5f5eeacb34813cd620f7ad83960b8a3e3db77e

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=63effa1b2ea515443954b55ee055c7dfa42648d8

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/149982e15470
[wpt PR 41426] - Add tolerance to IsSnapportCovered computation, a=testonly
https://hg.mozilla.org/integration/autoland/rev/9ce4ca427e7f
[wpt PR 41426] - Update wpt metadata, a=testonly

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/149982e15470
https://hg.mozilla.org/mozilla-central/rev/9ce4ca427e7f