1848416 - Consider removing network.http.enforce-framing.strict_chunked_encoding pref

Status: NEW

(Core :: Networking, task, P2)

Description

[Gregory Pappas [:gregp]]

Strict chunked encoding has been enabled for about 4 years now (bug 1531344). No new regressions have been reported, so it should be safe to remove this pref.

Comment 1

[endington543]

Hi, I'll try my hand at this bug if that's okay.

Comment 2

[Gregory Pappas [:gregp]]

Please go ahead, thanks!

Comment 3

[endington543]

Attachment: Bug 1848416 - Remove network.http.enforce-framing.strict_chunked_encoding/soft preferences and FrameCheckLevel enum r=sunil,#necko

Removed network.http.enforce-framing.strict_chunked_encoding preference from modules/libpref/init/all.js

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 5

[Sean Kim]

Should we remove enforce-framing.soft as well? Kershaw pointed out that removing enforce-framing.strict_chunked_encoding would make enforce-framing.soft useless in the Phabricator discussion.

Comment 6

[Valentin Gosu [:valentin] (he/him)]

If it doesn't make sense anymore, then we should remove it.

I doubt many people are changing this pref, but when removing them we need to make sure that:

1. We don't change behaviour.
2. None of these prefs are needed.

I think you can do a quick google search to check if there are any guides suggesting users change these prefs.

Comment 7

[Sean Kim]

Unassigned myself (temporarily) as the patch induced some failures which may require in-depth investigations: https://treeherder.mozilla.org/jobs?repo=try&revision=0b1eff0b9d56fb6b9d72992a1807e67a85515280.

Removed the good-first-bug keyword.