1848419 - Add toolchain for building custom Chromium-as-release for Android

Status: RESOLVED FIXED

(Testing :: Performance, task, P1)

Description

[Kash Shampur [:kshampur] ⌚EST]

the instructions provided by google here https://chromium.googlesource.com/chromium/src/+/main/docs/android_build_instructions.md

Example attempt at building the APK using https://treeherder.mozilla.org/jobs?repo=try&revision=17bd735e3c670a1214040c821b7134491a86f7ef

I was a bit confused/concerned about the PGO as unlike the desktop platform the format retrieved was different and I was required to use llvm-profdata. Why is/was this the case? maybe it's not a big deal. In general I also didn't really find much informatoin regarding their android PGO builds (but this was a cursory skim, i might find a clearer answer if i were to dig into the depot_tools src code)

Comment 1

[Kash Shampur [:kshampur] ⌚EST]

passing build Try link https://treeherder.mozilla.org/jobs?repo=try&revision=17bd735e3c670a1214040c821b7134491a86f7ef
(old, so artifacts have expired)
artifact was about ~90mb

Comment 2

[Kash Shampur [:kshampur] ⌚EST]

interesting looks like up until recently mac-arm pgo profiles were used for android pgo according to this

which might explain what i found a couple months ago (mentioned in comment 0 here) where I had to use llvm to merge the ARM profiles myself? (or it's possible I could have used the mac-arm back then too, was not aware that was being done)

recent comment suggests android profiles might be ready to go. Got a try run here with these new android profiles https://treeherder.mozilla.org/jobs?repo=try&revision=c95e5915d5ac5a6e0b9e43b2c007617437c13ddd&selectedTaskRun=EY66YFmHQ62EUCvAydzZKw.0

Comment 3

[Kash Shampur [:kshampur] ⌚EST]

making note that I will have to add a fetch for https://download-chromium.appspot.com/?platform=Android_Arm64&type=snapshots so that we can actually run performance tests with the apk

nevermind, we use a linux host so we should be using the linux driver

Comment 4

[Kash Shampur [:kshampur] ⌚EST]

Attachment: Bug 1848419 - Add a toolchain for building CaR for Android arm64. r?#perftest

Comment 5

[Kash Shampur [:kshampur] ⌚EST]

Attachment: Bug 1848419 - Run custom chromium-as-release performance tests on android. r?#perftest

This patch extends raptor to support running performance tests on chromium-as-release
for android (custom-car-m).
At the moment we will only run on priority benchmark tests (e.g. speedometer)

Depends on D189604

Comment 6

[Kash Shampur [:kshampur] ⌚EST]

passing try run ! https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=e63f2367a1c5959c4a077c54651b8e056674ff09
(i will remove the amazon test in the actual patch)

results arent being parsed. I will have to change the performance schema on the treeherder side for that

Comment 7

[Kash Shampur [:kshampur] ⌚EST]

PR made on treeherder side performance artifact json https://github.com/mozilla/treeherder/pull/7841

Comment 8

[Kash Shampur [:kshampur] ⌚EST]

Attachment: Bug 1848419 - Make custom-car android available in CI selection. r?#perftest

This patch adds support for custom-car android builds to be useable in performance testing.
Since android tests are run on a linux host, we make use of the existing chromium linux chromedriver fetch.

Depends on D189604

Comment 9

[Kash Shampur [:kshampur] ⌚EST]

Attachment: Bug 1848419 - Add CaR android to mach try perf. r?#perftest

This makes available Android CaR builds through mach try perf selector.
It is set up similar to the chrome-m application and becomes available for
selection when passing the --android and --custom-car flags.

Depends on D190579

Comment 10

[Kash Shampur [:kshampur] ⌚EST]

Attachment: Bug 1848419 - Add android CaR to daily m-c cron. r?#perftest

Depends on D191250

Comment 11

[Kash Shampur [:kshampur] ⌚EST]

I will queue this for landing on Monday

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48e3cbffbf9f
Add a toolchain for building CaR for Android arm64. r=perftest-reviewers,sparky
https://hg.mozilla.org/integration/autoland/rev/0e0a60ab85f9
Make custom-car android available in CI selection. r=perftest-reviewers,taskgraph-reviewers,AlexandruIonescu,bhearsum
https://hg.mozilla.org/integration/autoland/rev/9a325af6feb4
Run custom chromium-as-release performance tests on android. r=perftest-reviewers,aglavic
https://hg.mozilla.org/integration/autoland/rev/57ab54933fbb
Add CaR android to mach try perf. r=perftest-reviewers,AlexandruIonescu
https://hg.mozilla.org/integration/autoland/rev/02eefc6ff7a4
Add android CaR to daily m-c cron. r=perftest-reviewers,taskgraph-reviewers,bhearsum,sparky

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/48e3cbffbf9f
https://hg.mozilla.org/mozilla-central/rev/0e0a60ab85f9
https://hg.mozilla.org/mozilla-central/rev/9a325af6feb4
https://hg.mozilla.org/mozilla-central/rev/57ab54933fbb
https://hg.mozilla.org/mozilla-central/rev/02eefc6ff7a4