1848563 - Disabling 'search bookmarks' does not work

Status: RESOLVED INVALID

(Fenix :: Search, defect, P2)

Description

[Christian Ascheberg]

Steps to reproduce

1. Start with a clean profile
2. Go to "Settings" -> "Search" -> disable "Search bookmarks"
3. Open website, e.g. "example.org", in private browsing mode (so that there will be no history entry)
4. Add website as bookmark
5. Close tab
6. In a new tab start typing "example" into URL bar

Expected behavior

There should be no suggestions related to "example.org".

Actual behavior

Autocomplete suggests "example.org" and the website is also listed as Firefox suggestion (but the displayed entry does not have the star icon that is shown for bookmarks).

Device information

• Firefox version: 118.0a1
• Android device model: Pixel 4a
• Android OS version: 13

Any additional information?

Comment 1

[jackyzy823]

Maybe related https://bugzilla.mozilla.org/show_bug.cgi?id=1650511#c9 and https://bugzilla.mozilla.org/show_bug.cgi?id=1813898

Adding a bookmark will create a record in moz_origin , and search browsing history will refer this table.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:skhan, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Iorga Gabriel]

I think that disabling "Search Bookmarks" is working , the title is not good for this bug.
The problem is that when we save a bookmark in private mode, another history item is created, and that item is shown as a suggestion.
When we save a bookmark we only call "writer.createBookmarkItem(parentGuid, url, title, position)" writer is PlacesWriterConnection .
This suggestion comes from here
private suspend fun getHistorySuggestions(query: String) = historyStorage
.getSuggestions(query, maxNumberOfSuggestions)
.sortedByDescending { it.score }
.distinctBy { it.id }
.into(this@CombinedHistorySuggestionProvider, icons, loadUrlUseCase, showEditSuggestion)
So I think this bug is in app-services .

Comment 4

[Iorga Gabriel]

Attachment: Video of the bug .

Comment 5

[Iorga Gabriel]

I reopen this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1813898.

Comment 6

[Mark Hammond [:markh] [:mhammond]]

So this is subtle. When you create a bookmark an "origin" record is created.

Bug 1813898 was reporting that when you removed this bookmark, if there were no other visits for the URL the "origin" record remained. It now is correctly removed.

This bug however is different - it has nothing to do with bookmark removal. It is expected that while the bookmark exists an "origin" record exists for the origin of that bookmark.

Toolbar searching by default uses origins and URLs. So what I think might be happening is:

• You bookmark example.com/foo.
• By default you get autocomplete entries for example.com and example.com/foo
• If you turn off bookmark searching, you still get example.com, just not example.com/foo

Comment 7

[Iorga Gabriel]

"Toolbar searching by default uses origins and URLs. So what I think might be happening is:

You bookmark example.com/foo.
By default you get autocomplete entries for example.com and example.com/foo
If you turn off bookmark searching, you still get example.com, just not example.com/foo"
Yes this is correct ,I tested it .
So do you think this is a bug ? And if it is, can I fix it on my side?
Thank you very much .

Comment 8

[Zac McKenney [:zmckenney]]

Wanted to see if there is any update on whether this is something we should fix. We have this marked as an S2 for severity and it sounds like this may not actually be that severe and we aren't sure if this is something we need to fix.

Comment 9

[Iorga Gabriel]

I don't have any updates to this bug.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:skhan, since the bug has high severity and recent activity, could you have a look please?

For more information, please visit BugBot documentation.

Comment 11

[Mark Hammond [:markh] [:mhammond]]

While this may be surprising, I think it's working as intended and no one has proposed a change which would not also not work as expected for some users - so I'll close this for now.