1848580 - Add JSPropertySpec macro variant for value with WellKnownAtomId and replace JS_STRING_PS and JS_STRING_SYM_PS consumers

Status: ASSIGNED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

JSPropertySpec with string value holds const char* pointer and converts to JSAtom when defining the property.

https://searchfox.org/mozilla-central/search?q=JS_STRING_PS&path=
https://searchfox.org/mozilla-central/search?q=JS_STRING_SYM_PS&path=&case=false&regexp=false

https://searchfox.org/mozilla-central/rev/4647149548182ba7eb5c447d5a93abfca2f6acd6/js/src/jsapi.cpp#1984,1989-1991

JS_PUBLIC_API bool JSPropertySpec::getValue(JSContext* cx,
...
    case ValueWrapper::Type::String: {
      Rooted<JSAtom*> atom(cx,
                           Atomize(cx, u.value.string, strlen(u.value.string)));

In most case, the property is Symbol.toStringTag and the value is a member of proto key, which exists in well-known atom, and we don't have to perform extra atomization here.

bug 1847677 and related bugs will refactor the JSPropertySpec, in order to introduce well-known atom and embedding extension to the property key (not value),
so this can be done after that.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1848580 - Support JS::WellKnownAtomId as JSPropertySpec string value. r?jandem!

Depends on D192415