1848672 - filter_git_changes.py new regex handles files better, but not directory exclusion

Status: RESOLVED FIXED

(Core :: WebRTC, task)

Description

[Michael Froman [:mjf]]

Bug 1848373 fixed a case where an excluded file would cause a file with the same beginning characters (see '.vpython' and '.vpython3') to also be excluded when it should not. However, this breaks proper handling of excluding directories where we were relying on the more permissive regex. The list of excluded paths should be broken into 2 lists, one for files and one for directories to allow specific regex handling for each case.

Comment 1

[Michael Froman [:mjf]]

Attachment: Bug 1848672 - use separate lists for excluding files and excluding directories. r?dbaker!

Excluding directories requires different a different regex pattern
than excluding files. This breaks up the exclusion list into a
list for excluding files and a list for excluding directories.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/c1af549fa6ca
use separate lists for excluding files and excluding directories. r=dbaker

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c1af549fa6ca