Closed Bug 1848714 Opened 11 months ago Closed 11 months ago

Use unsafe methods in hot code paths to access and remove elements from nsTArray when it is guaranteed to be safe

Categories

(Core :: Layout, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
118 Branch
Tracking Status
firefox118 --- fixed

People

(Reporter: smaug, Assigned: smaug)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sp3])

Attachments

(1 file)

jlink did some testing and seems like the safety checks do add surprisingly lots of overhead.
So I was doing some profiling and will try to optimize the most common cases.

Summary: Use unsafe ways in hot code paths to access and remove elements from nsTArray when it is guaranteed to be safe → Use unsafe methods in hot code paths to access and remove elements from nsTArray when it is guaranteed to be safe
Attachment #9348946 - Attachment description: WIP: Bug 1848714 - Use unsafe methods in hot code paths to access and remove elements from nsTArray when it is guaranteed to be safe, r=emilio → Bug 1848714 - Use unsafe methods in hot code paths to access and remove elements from nsTArray when it is guaranteed to be safe, r=emilio
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/efe837c5a6e1
Use unsafe methods in hot code paths to access and remove elements from nsTArray when it is guaranteed to be safe, r=emilio
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
See Also: → 1855782
Regressions: 1855796
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: