Closed Bug 1848799 Opened 9 months ago Closed 9 months ago

Report crashes during wdspec tests as TEST-UNEXPECTED-CRASH

Categories

(Testing :: web-platform-tests, enhancement, P1)

Default
enhancement
Points:
2

Tracking

(firefox118 fixed)

RESOLVED FIXED
118 Branch
Tracking Status
firefox118 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

(Whiteboard: [webdriver:m8], [wptsync upstream])

Attachments

(1 file)

As right now we do not correctly report crashes of Firefox which could happen during the execution of wdspec tests, and as such failing tests are wrongly classified because the crash details as determined by mozcrash aren't taken into account. This could lead to missing information about crashes (maybe top-crashes) for Firefox where we could help developers in reproduction and fixing.

As such we should consider to report crashes correctly. Here a try build which shows a forced crash of Firefox by loading about:crashparent

https://treeherder.mozilla.org/logviewer?job_id=426057078&repo=try&lineNumber=7466

The downside is that we won't further run remaining tests in that particular pytest file. Probably that is fine for now.

I've submitted a try build to see how it works for existing non-modified wdspec tests:
https://treeherder.mozilla.org/jobs?repo=try&revision=0f14c379ab4f415a5b7a07d8015717da90681b9c

Points: --- → 2
Priority: -- → P1
Blocks: 1848850
Blocks: 1840019
No longer blocks: 1840019
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/351c8cb39e0a
[wdspec] Change test status for wdspec test to CRASH if browser crashed. r=webdriver-reviewers,jdescottes
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41536 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m8] → [webdriver:m8], [wptsync upstream]
Regressions: 1849416
Upstream PR was closed without merging

All the failures here in crash_content_process.py happened on LInux opt no fission builds. It should be marked as intermittent PASS / FAIL until the underlying issue has been fixed.

Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d66be226a1d7
[wdspec] Change test status for wdspec test to CRASH if browser crashed. r=webdriver-reviewers,jdescottes
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
Regressions: 1849669
Upstream PR merged by moz-wptsync-bot
Upstream PR merged by moz-wptsync-bot
Regressions: 1849719
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: