1848870 - Send an event when a user asks for reanalysis

Status: VERIFIED FIXED

(Firefox :: Shopping, task, P1)

Description

[Perry McManis [:perry.mcmanis]]

If you can click on it in the Shopping UI, we should record an event.

Comment 1

[Perry McManis [:perry.mcmanis]]

Attachment: WIP: Bug 1848870 - Instrument shopping clicks WIP

Comment 2

[Perry McManis [:perry.mcmanis]]

Attachment: shopping_ui_dr.txt

Data Review for a few UI events.

Comment 3

[Travis Long [:travis_]]

Comment on attachment 9349231 [details]
shopping_ui_dr.txt

Data Review

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the metrics.yaml file and the Glean Dictionary.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, through the data preferences in the application settings.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Permanent collection to be monitored by Bruce Etling, falling back to the [e-mail] team to ensure this data is necessary and useful over time.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction data

5. Is the data collection request for default-on or default-off?

Default-on

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No

7. Is the data collection covered by the existing Firefox privacy notice?

Yes

8. Does the data collection use a third-party collection tool?

No

Result

data-review+

Comment 4

[Perry McManis [:perry.mcmanis]]

Attachment: Bug 1848870 - Instrument some shopping clicks r?jhirsch,TravisLong

Comment 5

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

just repeating here what I've said on Slack - we'll need to split this into smaller bugs. "instrument all the clickable stuff" is fine as a placeholder, but not adequate for us to track the work to add a pretty substantial number of probes across the entire sidebar UI.

Comment 6

[Perry McManis [:perry.mcmanis]]

Attachment: Bug 1848870 - Instrument Shopping ReAnalysis Click r?jhirsch,TravisLong

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Setting severity to N/A as this is a Task.

Comment 8

[Perry McManis [:perry.mcmanis]]

Attachment: Bug 1848870 - Instrument Shopping ReAnalysis Click

Original Revision: https://phabricator.services.mozilla.com/D186559

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb32356f7b5c
Instrument Shopping ReAnalysis Click r=TravisLong,Gijs

Comment 10

[Cristian Tuns]

Backed out for causing bc failures in browser_ui_telemetry.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/shopping/tests/browser/browser_ui_telemetry.js | Uncaught exception in test bound test_shopping_UI_chevron_clicks - at chrome://mochitests/content/browser/browser/components/shopping/tests/browser/browser_ui_telemetry.js:45 - TypeError: can't access property "testGetValue", Glean.shopping.surfaceExpandSettings is undefined

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c46c856b1a3a
Instrument Shopping ReAnalysis Click r=TravisLong,Gijs

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c46c856b1a3a

Comment 13

[Pascal Chevrel:pascalc]

Perry, it seems that uplifting this patch is a dependency for uplifting bug 1849382 (https://lando.services.mozilla.com/D186951/) but you removed the review request on https://phabricator.services.mozilla.com/D186950, could you clarify what it meant for uplift and what is not? Thanks

Comment 14

[Perry McManis [:perry.mcmanis]]

(In reply to Pascal Chevrel:pascalc (PTO until August 21) from comment #13)

Perry, it seems that uplifting this patch is a dependency for uplifting bug 1849382 (https://lando.services.mozilla.com/D186951/) but you removed the review request on https://phabricator.services.mozilla.com/D186950, could you clarify what it meant for uplift and what is not? Thanks

Hey Pascal, I think that may have been automated when I removed this from a stack that got generated erroneously. Both should get uplifted please and thank you.

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/953c0cc7e2f0

Comment 16

[Peter Magyari (Desktop QA)]

Verified fixed using Firefox Nightly 119.0a1 (2023-09-06) on Windows 10, MacOS 11 and Ubuntu 20.04.

The "surface_reanalyze_clicked" ping is successfully displayed in about:glean after clicking the Re-analyze reviews link inside the shopping sidebar.